From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755508AbdDEOaF (ORCPT ); Wed, 5 Apr 2017 10:30:05 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46624 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755262AbdDEO2h (ORCPT ); Wed, 5 Apr 2017 10:28:37 -0400 Date: Wed, 5 Apr 2017 16:28:24 +0200 From: Andrew Lunn To: Ralph Sennhauser Cc: linux-arm-kernel@lists.infradead.org, Mark Rutland , Jason Cooper , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Gregory Clement , Rob Herring , Sebastian Hesselbarth Subject: Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Message-ID: <20170405142824.GB13449@lunn.ch> References: <20170405052847.326-1-ralph.sennhauser@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170405052847.326-1-ralph.sennhauser@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 05, 2017 at 07:28:46AM +0200, Ralph Sennhauser wrote: > The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. > "mamba:white:wan". So besides being an outlier with regard to the rest > of the product line (see table below) changing the label fixes an > internal inconsistency as well. > > This will be visible in user space. Given commit cb4f71c42988 ("ARM: > dts: armada-38x: change order of ethernet DT nodes on Armada 38x") it's > expected to happen anyway. Commit 499400c9ac20 ("ARM: dts: > armada-xp-linksys-mamba: Utilize new DSA binding") switches to the new > bindings, use this opportunity to do it now rather than later. > > |-----------------------------------------------------------------| > | Labels used for the case and those used for the DSA ports | > |-----------------------------------------------------------------| > | case labels | armada-385-linksys-* | armada-xp-linksys-mamba | > |---------------|-----------------------|-------------------------| > | internet | wan | internet | > | 1 | lan1 | lan1 | > | 2 | lan2 | lan2 | > | 3 | lan3 | lan3 | > | 4 | lan4 | lan4 | > |-----------------------------------------------------------------| Hi Ralph I always encourage people to use the case labels as interface names. So if i was going to make a change, it would be wan->internet for the armada-385-linksys-*. > I underestimated the urge of people to make all the same before. While I do not > particularly like this sort of change I see it coming anyway. So this patch is > meant to make it a deliberate decision so it no longer is an item lurking in > the shadows. Whether this patch gets taken or rejected my goal is reached. I would say, this is now too late. Changing an interface name will break configuration scripts. We are stuck with it. Andrew