From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933396AbdDERXE (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Apr 2017 13:23:04 -0400
Received: from mail.skyhub.de ([5.9.137.197]:58322 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755400AbdDERWI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Apr 2017 13:22:08 -0400
Date: Wed, 5 Apr 2017 19:22:04 +0200
From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>, "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] x86/mce/AMD: Redo use of SMCA MCA_DE{STAT,ADDR}
 registers
Message-ID: <20170405172203.stnpfpvtm2afzkvk@pd.tnic>
References: <1491326672-48298-1-git-send-email-Yazen.Ghannam@amd.com>
 <20170405133850.ihfyvle3sc5p4yer@pd.tnic>
 <BN6PR1201MB0131DADDCB1DE3C789EF2173F80A0@BN6PR1201MB0131.namprd12.prod.outlook.com>
 <20170405164433.jo2wghk7jvtsgdq7@pd.tnic>
 <BN6PR1201MB01314E3E7F751E1A68D6EE2EF80A0@BN6PR1201MB0131.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <BN6PR1201MB01314E3E7F751E1A68D6EE2EF80A0@BN6PR1201MB0131.namprd12.prod.outlook.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 05, 2017 at 05:06:19PM +0000, Ghannam, Yazen wrote:
> Checking if we have a valid deferred error. Since we call __log_error() on
> thresholding interrupts too we would need to tell it which handler is calling
> it to do the correct check. This is what we currently do.

That's why I suggested a __log_error_deferred() - a separate function
which deals with deferred errors.

> What do you mean " we don't have anything"? We check if we have a valid
> deferred error in is_deferred_error(). Otherwise, we don't log anything.

So the normal status MSR says whether we have a deferred error or not.
If it says we don't, then we have to look at the DE* MSRs, correct?

If yes, then do it exactly like this.

Not:

	IF deferred:
	 	log
	ELSE IF SMCA:
		IF deferred:
			log

but:

	IF deferred:
		log_deferred:
			log
			IF cannot log from normal MSRs
				log from DE

Why are we even wasting time with this?!

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.