mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Samuel Sieb <samuel@sieb.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: AMD IOMMU causing filesystem corruption
Date: Fri, 7 Apr 2017 12:27:39 +0200	[thread overview]
Message-ID: <20170407102739.GY7266@8bytes.org> (raw)
In-Reply-To: <5838b65d-0f2f-86b1-1041-a28d42fc9881@sieb.net>

On Tue, Apr 04, 2017 at 09:29:37AM -0700, Samuel Sieb wrote:
> That's what I did.  While running with iommu=off, I compiled and
> installed a 4.11rc kernel with the patch.  I rebooted to use that
> kernel and then compiled and installed a 4.10 kernel with that patch
> and another unrelated patch.  That is what I described above.  The
> filesystem destruction happened while running the 4.11rc kernel with
> that patch.  Is there any way to verify that the patch was actually
> having any effect?  Can I check if ATS is enabled or not?  I will
> have to rebuild the system before I can test again.

Also, please try the attached debug-diff on your kernel. It completly
disables the use of ATS in the amd-iommu driver.

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 98940d1392cb..f019aa67c54c 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -467,7 +467,7 @@ static int iommu_init_device(struct device *dev)
 		struct amd_iommu *iommu;
 
 		iommu = amd_iommu_rlookup_table[dev_data->devid];
-		dev_data->iommu_v2 = iommu->is_iommu_v2;
+		dev_data->iommu_v2 = false;
 	}
 
 	dev->archdata.iommu = dev_data;
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 6130278c5d71..41d0e645960c 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -171,7 +171,7 @@ int amd_iommus_present;
 
 /* IOMMUs have a non-present cache? */
 bool amd_iommu_np_cache __read_mostly;
-bool amd_iommu_iotlb_sup __read_mostly = true;
+bool amd_iommu_iotlb_sup __read_mostly = false;
 
 u32 amd_iommu_max_pasid __read_mostly = ~0;
 

  parent reply	other threads:[~2017-04-07 10:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 20:38 Samuel Sieb
2017-04-03 21:39 ` Joerg Roedel
2017-04-04  3:37   ` Samuel Sieb
2017-04-04  7:11     ` Samuel Sieb
2017-04-04  7:32       ` Joerg Roedel
2017-04-04 16:29         ` Samuel Sieb
2017-04-07 10:22           ` Joerg Roedel
2017-04-08  6:49             ` Samuel Sieb
2017-04-07 10:27           ` Joerg Roedel [this message]
2017-04-25 17:55             ` Samuel Sieb
2017-04-26 10:14               ` Joerg Roedel
2017-04-26 21:31                 ` Samuel Sieb
2017-04-26 21:43                   ` Joerg Roedel
2017-04-27 19:32                     ` Samuel Sieb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407102739.GY7266@8bytes.org \
    --to=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samuel@sieb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome