From: Matthias Kaehlcke <mka@chromium.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v3] regulator: Add driver for voltage controlled regulators
Date: Fri, 7 Apr 2017 11:44:09 -0700 [thread overview]
Message-ID: <20170407184409.GD78690@google.com> (raw)
In-Reply-To: <20170406182136.yrwdoyqeuz4qxc6d@sirena.org.uk>
Hi Mark,
Thanks for the review!
El Thu, Apr 06, 2017 at 07:21:36PM +0100 Mark Brown ha dit:
> On Fri, Mar 31, 2017 at 01:50:35PM -0700, Matthias Kaehlcke wrote:
>
> > +- compatible : must be "vctrl-regulator".
> > +- regulator-min-microvolt : smallest voltage consumers may set
> > +- regulator-max-microvolt : largest voltage consumers may set
> > +- ctrl-regulator: : the name of the regulator supplying the control
> > + voltage.
>
> This looks good except for this bit where we read the regulator name out
> of the DT, that's generally a sign of bad practice for things that are
> less simple passives than things like this or fixed voltage regulators.
> As with the supplies for fixed voltage regulators just pick a name for
> the supply (ctrl seems fine to me) and use that, neither option is
> perfect but at elast this less typing for everyone and it's consistent
> with what other similar things are already doing.
Sounds good, I will send out an updated version shortly.
Matthias
prev parent reply other threads:[~2017-04-07 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 20:50 Matthias Kaehlcke
2017-04-03 16:59 ` Rob Herring
2017-04-06 18:21 ` Mark Brown
2017-04-07 18:44 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407184409.GD78690@google.com \
--to=mka@chromium.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome