From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbdDJGcq (ORCPT ); Mon, 10 Apr 2017 02:32:46 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:35671 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266AbdDJGcn (ORCPT ); Mon, 10 Apr 2017 02:32:43 -0400 Date: Mon, 10 Apr 2017 12:02:39 +0530 From: Viresh Kumar To: Masahiro Yamada Cc: Rafael Wysocki , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Viresh Kumar , Nishanth Menon , Stephen Boyd , Rob Herring , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Maxime Ripard , Chen-Yu Tsai , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Linux Kernel Mailing List , Vincent Guittot , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel Subject: Re: [PATCH] PM / OPP: Use - instead of @ for DT entries Message-ID: <20170410063239.GB24555@vireshk-i7> References: <5ce1fbbc7cd37a6cfe54e93eeca311a7a52093ff.1491801395.git.viresh.kumar@linaro.org> <20170410062258.GA24555@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10-04-17, 15:30, Masahiro Yamada wrote: > 2017-04-10 15:22 GMT+09:00 Viresh Kumar : > > On 10-04-17, 10:46, Viresh Kumar wrote: > >> Compiling the DT file with W=1, DTC warns like follows: > >> > >> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a > >> unit name, but no reg property > >> > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a > >> "reg" property. > >> > >> Reported-by: Masahiro Yamada > >> Signed-off-by: Viresh Kumar > > > > + Reported-by: Krzysztof Kozlowski > > > > -- > > viresh > > > Given that this had already been reported one year before, > the reported-by credit should be given to Krzysztof. > > Please drop my Reported-by. I don't think we need to drop any of you. We can very well keep both :) -- viresh