From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753085AbdDJJbX (ORCPT ); Mon, 10 Apr 2017 05:31:23 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33168 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbdDJJam (ORCPT ); Mon, 10 Apr 2017 05:30:42 -0400 Date: Mon, 10 Apr 2017 15:00:38 +0530 From: Viresh Kumar To: Peter Zijlstra Cc: Ingo Molnar , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Vincent Guittot Subject: Re: [PATCH 0/4] sched: Minor cleanups Message-ID: <20170410093038.GG24555@vireshk-i7> References: <20170327135805.t3pnkomktsm4j2vw@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170327135805.t3pnkomktsm4j2vw@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-03-17, 15:58, Peter Zijlstra wrote: > On Thu, Mar 23, 2017 at 05:05:55PM +0530, Viresh Kumar wrote: > > Hi, > > > > Here are few minor cleanups for the sched core. The first three tries to > > avoid reinitializing memory which is already set to zero and the last > > one drops an unused statement. > > > > I'm OK with the kzalloc/memset thing, I assume that you are fine with removal of memset as done in the first 3 patches. Or you are fine with just the first patch? > but I'd prefer to keep all those > other bits. > > Yes they're superfluous, but this is init code, so nobody cares about > performance and having those things explitic makes it easier to read. Sure. > As to the very latest patch, that's there so that if/when we extend that > array we can simply continue. Also its more symmetric/consistent. Any > half sane DCE pass should get rid of it anyway, as the result is unused. But we aren't going to extend the array all the time and keeping a statement like that just for symmetry doesn't sound that great :). Anyway, I will drop the last patch as you suggested. -- viresh