mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Hugues Fruchet <hugues.fruchet@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Yannick Fertre <yannick.fertre@st.com>
Subject: Re: [PATCH v3 1/8] dt-bindings: Document STM32 DCMI bindings
Date: Mon, 10 Apr 2017 10:20:25 -0500	[thread overview]
Message-ID: <20170410152025.nx4zrnbth6wgamro@rob-hp-laptop> (raw)
In-Reply-To: <1491320678-17246-2-git-send-email-hugues.fruchet@st.com>

On Tue, Apr 04, 2017 at 05:44:31PM +0200, Hugues Fruchet wrote:
> This adds documentation of device tree bindings for the STM32 DCMI
> (Digital Camera Memory Interface).
> 
> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
> ---
>  .../devicetree/bindings/media/st,stm32-dcmi.txt    | 46 ++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.txt

One nit below, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt
> new file mode 100644
> index 0000000..c0f6f4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt
> @@ -0,0 +1,46 @@
> +STMicroelectronics STM32 Digital Camera Memory Interface (DCMI)
> +
> +Required properties:
> +- compatible: "st,stm32-dcmi"
> +- reg: physical base address and length of the registers set for the device
> +- interrupts: should contain IRQ line for the DCMI
> +- resets: reference to a reset controller,
> +          see Documentation/devicetree/bindings/reset/st,stm32-rcc.txt
> +- clocks: list of clock specifiers, corresponding to entries in
> +          the clock-names property
> +- clock-names: must contain "mclk", which is the DCMI peripherial clock
> +- pinctrl: the pincontrol settings to configure muxing properly
> +           for pins that connect to DCMI device.
> +           See Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt.
> +- dmas: phandle to DMA controller node,
> +        see Documentation/devicetree/bindings/dma/stm32-dma.txt
> +- dma-names: must contain "tx", which is the transmit channel from DCMI to DMA
> +
> +DCMI supports a single port node with parallel bus. It should contain one
> +'port' child node with child 'endpoint' node. Please refer to the bindings
> +defined in Documentation/devicetree/bindings/media/video-interfaces.txt.
> +
> +Example:
> +
> +	dcmi: dcmi@50050000 {
> +		compatible = "st,stm32-dcmi";
> +		reg = <0x50050000 0x400>;
> +		interrupts = <78>;
> +		resets = <&rcc STM32F4_AHB2_RESET(DCMI)>;
> +		clocks = <&rcc 0 STM32F4_AHB2_CLOCK(DCMI)>;
> +		clock-names = "mclk";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&dcmi_pins>;
> +		dmas = <&dma2 1 1 0x414 0x3>;
> +		dma-names = "tx";
> +		port {
> +			dcmi_0: endpoint@0 {

Unit address in not valid without a reg prop, so drop it.

> +				remote-endpoint = <...>;
> +				bus-width = <8>;
> +				hsync-active = <0>;
> +				vsync-active = <0>;
> +				pclk-sample = <1>;
> +			};
> +		};
> +	};
> +
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-04-10 15:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 15:44 [PATCH v3 0/8] Add support for DCMI camera interface of STMicroelectronics STM32 SoC series Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 1/8] dt-bindings: Document STM32 DCMI bindings Hugues Fruchet
2017-04-10 15:20   ` Rob Herring [this message]
2017-04-04 15:44 ` [PATCH v3 2/8] [media] stm32-dcmi: STM32 DCMI camera interface driver Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 3/8] ARM: dts: stm32: Enable DCMI support on STM32F429 MCU Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 4/8] ARM: dts: stm32: Enable DCMI camera interface on STM32F429-EVAL board Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 5/8] ARM: dts: stm32: Enable STMPE1600 gpio expander of " Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 6/8] ARM: dts: stm32: Enable OV2640 camera support " Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 7/8] ARM: configs: stm32: STMPE1600 GPIO expander Hugues Fruchet
2017-04-04 15:44 ` [PATCH v3 8/8] ARM: configs: stm32: DCMI + OV2640 camera support Hugues Fruchet
2017-04-10  8:55 ` [PATCH v3 0/8] Add support for DCMI camera interface of STMicroelectronics STM32 SoC series Hans Verkuil
2017-04-20 16:31   ` Hugues FRUCHET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170410152025.nx4zrnbth6wgamro@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hugues.fruchet@st.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®