From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbdDJQQL (ORCPT ); Mon, 10 Apr 2017 12:16:11 -0400 Received: from muru.com ([72.249.23.125]:43796 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbdDJQQI (ORCPT ); Mon, 10 Apr 2017 12:16:08 -0400 Date: Mon, 10 Apr 2017 09:15:59 -0700 From: Tony Lindgren To: Johan Hovold Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Shubhrajyoti D Subject: Re: [PATCH 2/2] serial: omap: suspend device on probe errors Message-ID: <20170410161559.GB5339@atomide.com> References: <20170410092139.11441-1-johan@kernel.org> <20170410092139.11441-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170410092139.11441-2-johan@kernel.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Johan Hovold [170410 02:27]: > Make sure to actually suspend the device before returning after a failed > (or deferred) probe. > > Note that autosuspend must be disabled before runtime pm is disabled in > order to balance the usage count due to a negative autosuspend delay as > well as to make the final put suspend the device synchronously. > > Fixes: 388bc2622680 ("omap-serial: Fix the error handling in the omap_serial probe") > Cc: Shubhrajyoti D > Cc: Tony Lindgren > Signed-off-by: Johan Hovold Acked-by: Tony Lindgren