From: Wei Yang <richard.weiyang@gmail.com>
To: kirill@shutemov.name, bp@alien8.de, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, tj@kernel.org
Cc: linux-kernel@vger.kernel.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed
Date: Tue, 11 Apr 2017 00:56:51 +0800 [thread overview]
Message-ID: <20170410165652.50250-3-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20170410165652.50250-1-richard.weiyang@gmail.com>
According to current code path, numa_nodes_parsed is already setup when
numa_emucation() is called.
x86_numa_init()
numa_init()
init_func()
numa_emulation()
numa_register_memblks()
This means we can get the physnode_mask directly from numa_nodes_parsed. At
the same time, this patch correct the comment of these two functions.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
arch/x86/mm/numa_emulation.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/arch/x86/mm/numa_emulation.c b/arch/x86/mm/numa_emulation.c
index eb017c816de6..a6d01931b9a1 100644
--- a/arch/x86/mm/numa_emulation.c
+++ b/arch/x86/mm/numa_emulation.c
@@ -75,13 +75,15 @@ static int __init emu_setup_memblk(struct numa_meminfo *ei,
/*
* Sets up nr_nodes fake nodes interleaved over physical nodes ranging from addr
- * to max_addr. The return value is the number of nodes allocated.
+ * to max_addr.
+ *
+ * Returns zero on success or negative error code.
*/
static int __init split_nodes_interleave(struct numa_meminfo *ei,
struct numa_meminfo *pi,
u64 addr, u64 max_addr, int nr_nodes)
{
- nodemask_t physnode_mask = NODE_MASK_NONE;
+ nodemask_t physnode_mask = numa_nodes_parsed;
u64 size;
int big;
int nid = 0;
@@ -116,9 +118,6 @@ static int __init split_nodes_interleave(struct numa_meminfo *ei,
return -1;
}
- for (i = 0; i < pi->nr_blks; i++)
- node_set(pi->blk[i].nid, physnode_mask);
-
/*
* Continue to fill physical nodes with fake nodes until there is no
* memory left on any of them.
@@ -200,13 +199,15 @@ static u64 __init find_end_of_node(u64 start, u64 max_addr, u64 size)
/*
* Sets up fake nodes of `size' interleaved over physical nodes ranging from
- * `addr' to `max_addr'. The return value is the number of nodes allocated.
+ * `addr' to `max_addr'.
+ *
+ * Returns zero on success or negative error code.
*/
static int __init split_nodes_size_interleave(struct numa_meminfo *ei,
struct numa_meminfo *pi,
u64 addr, u64 max_addr, u64 size)
{
- nodemask_t physnode_mask = NODE_MASK_NONE;
+ nodemask_t physnode_mask = numa_nodes_parsed;
u64 min_size;
int nid = 0;
int i, ret;
@@ -231,9 +232,6 @@ static int __init split_nodes_size_interleave(struct numa_meminfo *ei,
}
size &= FAKE_NODE_MIN_HASH_MASK;
- for (i = 0; i < pi->nr_blks; i++)
- node_set(pi->blk[i].nid, physnode_mask);
-
/*
* Fill physical nodes with fake nodes of size until there is no memory
* left on any of them.
--
2.11.0
next prev parent reply other threads:[~2017-04-10 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 16:56 [PATCH 0/3] Refine numa_emulation Wei Yang
2017-04-10 16:56 ` [PATCH 1/3] x86/numa_emulation: fix potential memory leak Wei Yang
2017-04-11 0:16 ` David Rientjes
2017-04-10 16:56 ` Wei Yang [this message]
2017-04-11 0:26 ` [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed David Rientjes
2017-04-11 1:42 ` Wei Yang
2017-05-01 21:37 ` David Rientjes
2017-05-02 13:06 ` Wei Yang
2017-04-10 16:56 ` [PATCH 3/3] x86/numa_emulation: restructures numa_nodes_parsed from emulated nodes Wei Yang
2017-04-11 0:36 ` David Rientjes
2017-04-11 1:44 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410165652.50250-3-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®