From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbdDKAFh (ORCPT ); Mon, 10 Apr 2017 20:05:37 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:34659 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753221AbdDKAFg (ORCPT ); Mon, 10 Apr 2017 20:05:36 -0400 Date: Tue, 11 Apr 2017 09:05:23 +0900 From: Tejun Heo To: Todd Poynor Cc: Li Zefan , Johannes Weiner , cgroups@vger.kernel.org, Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, kernel-team@android.com, Todd Poynor Subject: Re: [PATCH v2] cgroup: move cgroup_subsys_state parent field for cache locality Message-ID: <20170411000523.GD28603@wtj.duckdns.org> References: <1491529677-707-1-git-send-email-todd@tjlinux.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1491529677-707-1-git-send-email-todd@tjlinux.dyndns.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Apr 06, 2017 at 06:47:57PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Various structures embed a struct cgroup_subsys_state, typically at > the top of the containing structure. It is common for code that > accesses the structures to perform operations that iterate over the > chain of parent css pointers, also accessing data in each containing > structure. In particular, struct cpuacct is used by fairly hot code > paths in the scheduler such as cpuacct_charge(). > > Move the parent css pointer field to the end of the structure to > increase the chances of residing in the same cache line as the data > from the containing structure. > > Signed-off-by: Todd Poynor Applied to cgroup/for-4.12. Thanks. -- tejun