From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754623AbdDKJSU (ORCPT ); Tue, 11 Apr 2017 05:18:20 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:33548 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754446AbdDKJSR (ORCPT ); Tue, 11 Apr 2017 05:18:17 -0400 Date: Tue, 11 Apr 2017 10:18:08 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Jonathan Cameron , Olof Johansson , bleung@chromium.org, martinez.javier@gmail.com, Guenter Roeck , Gwendal Grignou , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, rtc-linux@googlegroups.com, Vic Yang Subject: Re: [PATCH v2 1/5] mfd: cros-ec: Fix host command buffer size Message-ID: <20170411091808.trx6xc7vl72c3rav@dell> References: <20170403163536.25634-1-enric.balletbo@collabora.com> <20170403163536.25634-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170403163536.25634-2-enric.balletbo@collabora.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Apr 2017, Enric Balletbo i Serra wrote: > From: Vic Yang > > For SPI, we can get up to 32 additional bytes for response preamble. > The current overhead (2 bytes) may cause problems when we try to receive > a big response. Update it to 32 bytes. > > Without this fix we could see a kernel BUG when we receive a big response > from the Chrome EC when is connected via SPI. > > Signed-off-by: Vic Yang > Tested-by: Enric Balletbo i Serra > --- > > This patch is a FIX, and I think that would be interesting see it merged > in this release cycle. This should go through the MFD tree and can be picked > independently of the other patches. Lee Jones I think this is for you. > > Changes since v1: > - None > > include/linux/mfd/cros_ec.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch is already in Mainline. > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index b3e812f..3b16c90 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -35,10 +35,11 @@ > * Max bus-specific overhead incurred by request/responses. > * I2C requires 1 additional byte for requests. > * I2C requires 2 additional bytes for responses. > + * SPI requires up to 32 additional bytes for responses. > * */ > #define EC_PROTO_VERSION_UNKNOWN 0 > #define EC_MAX_REQUEST_OVERHEAD 1 > -#define EC_MAX_RESPONSE_OVERHEAD 2 > +#define EC_MAX_RESPONSE_OVERHEAD 32 > > /* > * Command interface between EC and AP, for LPC, I2C and SPI interfaces. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog