mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tobias Regnery <tobias.regnery@gmail.com>
To: dhowells@redhat.com, james.l.morris@oracle.com, serge@hallyn.com,
	linux-kernel@vger.kernel.org
Cc: smueller@chronox.de, Tobias Regnery <tobias.regnery@gmail.com>
Subject: [PATCH] KEYS: fix build failure with CONFIG_KEY_DH_OPERATIONS
Date: Tue, 11 Apr 2017 14:45:12 +0200	[thread overview]
Message-ID: <20170411124512.23627-1-tobias.regnery@gmail.com> (raw)

With CONFIG_KEY_DH_OPERATIONS=y and CONFIG_CRYPTO=m we get the following
link error:

security/built-in.o: In function `__keyctl_dh_compute':
device_cgroup.c:(.text+0x925c): undefined reference to 'crypto_alloc_shash'
device_cgroup.c:(.text+0x9510): undefined reference to 'crypto_shash_update'
device_cgroup.c:(.text+0x9548): undefined reference to 'crypto_shash_update'
device_cgroup.c:(.text+0x957c): undefined reference to 'crypto_shash_final'
device_cgroup.c:(.text+0x95d0): undefined reference to 'crypto_shash_final'
device_cgroup.c:(.text+0x9710): undefined reference to 'crypto_destroy_tfm'

Fix this by selecting the crypto core in order to reach the functions above.

Fixes: f1c316a3ab9d ("KEYS: add SP800-56A KDF support for DH")
Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
---
 security/keys/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index 4ac1b83a23f8..6fd95f76bfae 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -90,6 +90,7 @@ config KEY_DH_OPERATIONS
        bool "Diffie-Hellman operations on retained keys"
        depends on KEYS
        select MPILIB
+       select CRYPTO
        select CRYPTO_HASH
        help
 	 This option provides support for calculating Diffie-Hellman
-- 
2.11.0

             reply	other threads:[~2017-04-11 12:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 12:45 Tobias Regnery [this message]
2017-04-11 13:47 ` Stephan Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411124512.23627-1-tobias.regnery@gmail.com \
    --to=tobias.regnery@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®