From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111AbdDKKvM (ORCPT ); Tue, 11 Apr 2017 06:51:12 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:50788 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752712AbdDKKtw (ORCPT ); Tue, 11 Apr 2017 06:49:52 -0400 Date: Tue, 11 Apr 2017 12:49:39 +0200 From: Petr Tesarik To: Daniel Kiper Cc: jgross@suse.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, eric.devolder@oracle.com, dkiper@net-space.pl, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Message-ID: <20170411124939.6cb7a33e@hananiah.suse.cz> In-Reply-To: <20170410204933.GZ4372@olila.local.net-space.pl> References: <0106a5b2-7c66-41bd-9a43-42974242b3af@default> <20170405131300.6a92fd6a@hananiah.suse.cz> <20170407111622.3dfe44fe@hananiah.suse.cz> <20170410204933.GZ4372@olila.local.net-space.pl> Organization: SUSE Linux X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Apr 2017 22:49:33 +0200 Daniel Kiper wrote: > On Fri, Apr 07, 2017 at 11:16:22AM +0200, Petr Tesarik wrote: > > On Wed, 5 Apr 2017 13:13:00 +0200 > > Petr Tesarik wrote: > > > > > On Tue, 4 Apr 2017 12:42:53 -0700 (PDT) > > > Daniel Kiper wrote: > > > > > >[...] > > > > So, if Petr did relevant tests that is nice. However, then, IMO, this > > > > patch begs Petr Tested-by. > > > > > > Actually, I tested with this patch applied on top of kernel 4.4 (SLES > > > 12 SP2). It matches what traditional Xen had always done, so I am quite > > > confident it will work with a later kernel, but to give my Tested-by, > > > let me first re-run the test on master, hopefully until today EOB. > > > > It took me much longer than anticipated (I had some trouble setting up > > the host again), but I can confirm that the patch works as expected on > > No problem. I know how it works. > > > top of 4.11-rc5. > > Great! > > > Without the patch, makedumpfile in the crash kernel complains: > > > > /proc/vmcore doesn't contain vmcoreinfo. > > Though, I would like to ask you to do crash tool tests too. > Could you do that? I'm not sure what kind of tests you want me to perform. I'm not able to save a dump file without the patch. Well ... I could reserve enough memory to launch a crash session directly in the kdump environment. I'll get to you later. > > With the patch applied, dumping still fails later because of an > > unrelated bug in makedumpfile, but I was able to extract the kernel > > message buffer with "makedumpfile --dump-dmesg". This already confirms > > VMCOREINFO presence and usability. > > Is it Xen specific issue or more generic one? It is Xen-specific, and I even have a patch now, about to be sent to the kexec ML. Petr T