From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbdDKPKg (ORCPT ); Tue, 11 Apr 2017 11:10:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33142 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbdDKPKe (ORCPT ); Tue, 11 Apr 2017 11:10:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6B1A6C04B955 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6B1A6C04B955 Date: Tue, 11 Apr 2017 10:10:30 -0500 From: Josh Poimboeuf To: Petr Mladek Cc: Miroslav Benes , Jessica Yu , Jiri Kosina , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH] livepatch: Cancel transition a safe way for immediate patches Message-ID: <20170411151030.7mbg2zjvoxo5ffxv@treble> References: <1491908868-27766-1-git-send-email-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1491908868-27766-1-git-send-email-pmladek@suse.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 11 Apr 2017 15:10:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2017 at 01:07:48PM +0200, Petr Mladek wrote: > klp_init_transition() does not set func->transition for immediate patches. > Then klp_ftrace_handler() could use the new code immediately. As a result, > it is not safe to put the livepatch module in klp_cancel_transition(). > > This patch reverts most of the last minute changes klp_cancel_transition(). > It keeps the warning about a misuse because it still makes sense. > > Signed-off-by: Petr Mladek Good catch Petr, thanks! Fixes: 3ec24776bfd0 ("livepatch: allow removal of a disabled patch") Acked-by: Josh Poimboeuf -- Josh