From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbdDKQep (ORCPT ); Tue, 11 Apr 2017 12:34:45 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37965 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbdDKQem (ORCPT ); Tue, 11 Apr 2017 12:34:42 -0400 Date: Tue, 11 Apr 2017 17:34:38 +0100 From: Lee Jones To: Kishon Vijay Abraham I Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/32] mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header Message-ID: <20170411163438.yhbe22v34d7chit3@dell> References: <20170410131823.26485-1-kishon@ti.com> <20170410131823.26485-2-kishon@ti.com> <20170411141407.ghpln5u5re5erqud@dell> <3268f5fd-218f-21d4-cc19-39812b58b8ea@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3268f5fd-218f-21d4-cc19-39812b58b8ea@ti.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 11 April 2017 07:44 PM, Lee Jones wrote: > > On Mon, 10 Apr 2017, Kishon Vijay Abraham I wrote: > > > >> From: Krzysztof Kozlowski > >> > >> The MFD-specific header will go away because it duplicates defines from > >> exynos-regs-pmu.h. > >> > >> Reported-by: kbuild test robot > >> Signed-off-by: Krzysztof Kozlowski > >> Reviewed-by: Bartlomiej Zolnierkiewicz > >> Signed-off-by: Lee Jones > > > > > > Okay, this is confusing. > > > > I'm guessing you're sending this to Greg for inclusion into -stable? > > No, it's not for stable. It's for 4.12. Then I'm totally confused, since this patch has already been applied, which is obvious since I already signed it off? > > Isn't there a way to specify this intention? > > The pull request (cover letter) specifies this intention. Great! But you forgot to send it to me, doh! Why are you sending patches with a pull-request? > > Also, patch 1 and 3 appear to be identical. > > > > Not even sure how that's possible. Still have no idea how you managed to do this! > >> Signed-off-by: Kishon Vijay Abraham I > >> --- > >> drivers/mfd/exynos-lpass.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c > >> index 2e064fb8826f..8bebad92a385 100644 > >> --- a/drivers/mfd/exynos-lpass.c > >> +++ b/drivers/mfd/exynos-lpass.c > >> @@ -18,11 +18,11 @@ > >> #include > >> #include > >> #include > >> -#include > >> #include > >> #include > >> #include > >> #include > >> +#include > >> #include > >> > >> /* LPASS Top register definitions */ > >> @@ -83,7 +83,7 @@ static void exynos_lpass_enable(struct exynos_lpass *lpass) > >> > >> /* Activate related PADs from retention state */ > >> regmap_write(lpass->pmu, EXYNOS5433_PAD_RETENTION_AUD_OPTION, > >> - EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR); > >> + EXYNOS_WAKEUP_FROM_LOWPWR); > >> > >> exynos_lpass_core_sw_reset(lpass, LPASS_I2S_SW_RESET); > >> exynos_lpass_core_sw_reset(lpass, LPASS_DMA_SW_RESET); > >> > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog