From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbdDKW4I (ORCPT ); Tue, 11 Apr 2017 18:56:08 -0400 Received: from mail.kernel.org ([198.145.29.136]:50484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdDKW4F (ORCPT ); Tue, 11 Apr 2017 18:56:05 -0400 Date: Tue, 11 Apr 2017 18:56:01 -0400 From: Steven Rostedt To: "Paul E. McKenney" Cc: LKML Subject: Re: [PATCH] tracing: Have the trace_event benchmark thread call cond_resched_rcu_qs() Message-ID: <20170411185601.01b32a0e@gandalf.local.home> In-Reply-To: <20170411185435.313ce179@gandalf.local.home> References: <20170411185435.313ce179@gandalf.local.home> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017 18:54:35 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The trace_event benchmark thread runs in kernel space in an infinite loop > while also calling cond_resched() in case anything else wants to schedule > in. Unfortunately, on a PREEMPT kernel, that makes it a nop, in which case, > this will never voluntarily schedule. That will cause synchronize_rcu_tasks() > to forever block on this thread, while it is running. > > This is exactly what cond_resched_rcu_qs() is for. Use that instead. > > Cc: "Paul E. McKenney" This actually should be: Recommended-by: "Paul E. McKenney" -- Steve > Signed-off-by: Steven Rostedt (VMware) > ---