From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbdDKUFO (ORCPT ); Tue, 11 Apr 2017 16:05:14 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:24337 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766AbdDKUFM (ORCPT ); Tue, 11 Apr 2017 16:05:12 -0400 Date: Tue, 11 Apr 2017 16:04:59 -0400 From: Konrad Rzeszutek Wilk To: Marc Olson Cc: xen-devel@lists.xenproject.org, Roger Pau =?iso-8859-1?Q?Monn=E9?= , Boris Ostrovsky , David Vrabel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] blkfront: add uevent for size change Message-ID: <20170411200459.GB30956@char.us.oracle.com> References: <20170411192403.GA26778@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411192403.GA26778@amazon.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2017 at 12:24:09PM -0700, Marc Olson wrote: > When a blkfront device is resized from dom0, emit a KOBJ_CHANGE uevent to > notify the guest about the change. This allows for custom udev rules, such > as automatically resizing a filesystem, when an event occurs. Looks pretty reasonable. Could you confirm what the udevadm --monitor --kernel --udev emits when this happens? Thanks! > > Signed-off-by: Marc Olson > --- > drivers/block/xen-blkfront.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > index 2fee2ee..66abf9c 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -1996,6 +1996,7 @@ static void blkfront_connect(struct blkfront_info *info) > unsigned long sector_size; > unsigned int physical_sector_size; > unsigned int binfo; > + char *envp[] = { "RESIZE=1", NULL }; > int err; > > switch (info->connected) { > @@ -2012,6 +2013,8 @@ static void blkfront_connect(struct blkfront_info *info) > sectors); > set_capacity(info->gd, sectors); > revalidate_disk(info->gd); > + kobject_uevent_env(&disk_to_dev(info->gd)->kobj, > + KOBJ_CHANGE, envp); > > return; > case BLKIF_STATE_SUSPENDED: > -- > 2.7.4 >