From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755848AbdDMBwN (ORCPT ); Wed, 12 Apr 2017 21:52:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:53006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755174AbdDMBwL (ORCPT ); Wed, 12 Apr 2017 21:52:11 -0400 Date: Wed, 12 Apr 2017 21:52:06 -0400 (EDT) Message-Id: <20170412.215206.1568460664651298892.davem@davemloft.net> To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@kernel.org, bigeasy@linutronix.de, benh@kernel.crashing.org, fenghua.yu@intel.com, herbert@gondor.apana.org.au, jiangshanlai@gmail.com, lenb@kernel.org, mpe@ellerman.id.au, rjw@rjwysocki.net, tj@kernel.org, tony.luck@intel.com, viresh.kumar@linaro.org, sparclinux@vger.kernel.org Subject: Re: [patch 06/13] sparc/sysfs: Replace racy task affinity logic From: David Miller In-Reply-To: <20170412201042.612462984@linutronix.de> References: <20170412200726.941336635@linutronix.de> <20170412201042.612462984@linutronix.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 12 Apr 2017 18:10:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner Date: Wed, 12 Apr 2017 22:07:32 +0200 > @@ -142,7 +122,8 @@ static unsigned long write_mmustat_enabl > static ssize_t show_mmustat_enable(struct device *s, > struct device_attribute *attr, char *buf) > { > - unsigned long val = run_on_cpu(s->id, read_mmustat_enable, 0); > + long val = work_on_cpu(s->id, read_mmustat_enable, 0); Last argument to work_on_cpu() should be NULL since it's a pointer I guess. But otherwise I have no problems with this: Acked-by: David S. Miller