From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740AbdDLP2V (ORCPT ); Wed, 12 Apr 2017 11:28:21 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37463 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbdDLP2S (ORCPT ); Wed, 12 Apr 2017 11:28:18 -0400 Date: Wed, 12 Apr 2017 18:28:08 +0300 From: "Kirill A. Shutemov" To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com, hpa@zytor.com, tglx@linutronix.de, kirill.shutemov@linux.intel.com Subject: Re: [PATCH] x86/mm: fix dump pagetables for 4 levels of page tables Message-ID: <20170412152808.mrzezql3tf554agk@node.shutemov.name> References: <20170412143634.6846-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412143634.6846-1-jgross@suse.com> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 04:36:34PM +0200, Juergen Gross wrote: > Commit fdd3d8ce0ea62 ("x86/dump_pagetables: Add support for 5-level > paging") introduced an error for dumping with only 4 levels by setting > PGD_LEVEL_MULT to a wrong value. > > This is leading to e.g. addresses printed as "(null)" for ranges: > > x86/mm: Found insecure W+X mapping at address (null)/(null) > > Signed-off-by: Juergen Gross Sorry for this. Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov