From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755006AbdDLRcc (ORCPT ); Wed, 12 Apr 2017 13:32:32 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:32982 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304AbdDLRc3 (ORCPT ); Wed, 12 Apr 2017 13:32:29 -0400 Date: Wed, 12 Apr 2017 10:32:28 -0700 From: Christoph Hellwig To: Leno Hou Cc: Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function Message-ID: <20170412173228.GB23054@infradead.org> References: <1491893636-60759-1-git-send-email-lenohou@gmail.com> <20170411162051.GA26560@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 06:03:10PM +0800, Leno Hou wrote: > 1. Actually, this is cleanup of the code to human being read but not > optimize. And When I compiled the kernel > and checked with object code . It proved as same as before. So it's no > need to test this change. > > 2. This Simple B+ Tree in Memory was used by SCSI driver QLA2XXX. so it > would be better to merge this > cleanup for future optimize. Thanks. If you care about the btree code a good first step would be to write a test suite instead of micro-optimizing it out of the blue without actually being able to test it.