From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Lucas Stach <l.stach@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
etnaviv@lists.freedesktop.org
Subject: [PATCH v2 4/5] drm/etnaviv: Reuse dma_fence_release.
Date: Wed, 12 Apr 2017 12:12:01 -0700 [thread overview]
Message-ID: <20170412191202.22740-5-eric@anholt.net> (raw)
In-Reply-To: <20170412191202.22740-1-eric@anholt.net>
If we follow the typical pattern of the base class being the first
member, we can use the default dma_fence_free function.
Signed-off-by: Eric Anholt <eric@anholt.net>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Russell King <linux+etnaviv@armlinux.org.uk>
Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
Cc: etnaviv@lists.freedesktop.org
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index da48819ff2e6..0d26ca56e94b 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -998,8 +998,8 @@ static void hangcheck_disable(struct etnaviv_gpu *gpu)
/* fence object management */
struct etnaviv_fence {
- struct etnaviv_gpu *gpu;
struct dma_fence base;
+ struct etnaviv_gpu *gpu;
};
static inline struct etnaviv_fence *to_etnaviv_fence(struct dma_fence *fence)
@@ -1031,20 +1031,13 @@ static bool etnaviv_fence_signaled(struct dma_fence *fence)
return fence_completed(f->gpu, f->base.seqno);
}
-static void etnaviv_fence_release(struct dma_fence *fence)
-{
- struct etnaviv_fence *f = to_etnaviv_fence(fence);
-
- kfree_rcu(f, base.rcu);
-}
-
static const struct dma_fence_ops etnaviv_fence_ops = {
.get_driver_name = etnaviv_fence_get_driver_name,
.get_timeline_name = etnaviv_fence_get_timeline_name,
.enable_signaling = etnaviv_fence_enable_signaling,
.signaled = etnaviv_fence_signaled,
.wait = dma_fence_default_wait,
- .release = etnaviv_fence_release,
+ .release = dma_fence_free,
};
static struct dma_fence *etnaviv_gpu_fence_alloc(struct etnaviv_gpu *gpu)
--
2.11.0
next prev parent reply other threads:[~2017-04-12 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 19:11 [PATCH v2 0/5] vc4 V3D fencing and msm/etnaviv cleanups Eric Anholt
2017-04-12 19:11 ` [PATCH v2 1/5] drm/msm: Expose our reservation object when exporting a dmabuf Eric Anholt
2017-05-02 10:20 ` Rob Clark
2017-04-12 19:11 ` [PATCH v2 2/5] drm/etnaviv: " Eric Anholt
2017-04-12 19:12 ` [PATCH v2 3/5] drm/msm: Reuse dma_fence_release Eric Anholt
2017-05-02 10:20 ` Rob Clark
2017-04-12 19:12 ` Eric Anholt [this message]
2017-04-13 7:00 ` [PATCH v2 4/5] drm/etnaviv: " Daniel Vetter
2017-05-03 10:19 ` Lucas Stach
2017-05-03 16:03 ` Eric Anholt
2017-04-12 19:12 ` [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering Eric Anholt
2017-04-13 7:13 ` Daniel Vetter
2017-04-13 17:16 ` Eric Anholt
2017-04-13 18:01 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412191202.22740-5-eric@anholt.net \
--to=eric@anholt.net \
--cc=christian.gmeiner@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®