From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756133AbdDMFxm (ORCPT ); Thu, 13 Apr 2017 01:53:42 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51828 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbdDMFxk (ORCPT ); Thu, 13 Apr 2017 01:53:40 -0400 Date: Thu, 13 Apr 2017 11:23:30 +0530 From: "Naveen N. Rao" To: Masami Hiramatsu Cc: Michael Ellerman , Ananth N Mavinakayanahalli , Ingo Molnar , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] powerpc: kprobes: emulate instructions on kprobe handler re-entry References: <7021f79a5738ecb25ee3e07931e927138e9493eb.1491991939.git.naveen.n.rao@linux.vnet.ibm.com> <20170413133758.0f9e0c86bd3230dcd820f8e7@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413133758.0f9e0c86bd3230dcd820f8e7@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable x-cbid: 17041305-0016-0000-0000-00000408C6CA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041305-0017-0000-0000-000028F250D5 Message-Id: <20170413055330.GD30806@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-13_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704130047 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/04/13 01:37PM, Masami Hiramatsu wrote: > On Wed, 12 Apr 2017 16:28:28 +0530 > "Naveen N. Rao" wrote: > > > On kprobe handler re-entry, try to emulate the instruction rather than > > single stepping always. > > > > > As a related change, remove the duplicate saving of msr as that is > > already done in set_current_kprobe() > > If so, this part might be separated as a cleanup patch... Sure, thanks for the review! - Naveen