From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbdDMIQS (ORCPT ); Thu, 13 Apr 2017 04:16:18 -0400 Received: from mga06.intel.com ([134.134.136.31]:4751 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbdDMIQQ (ORCPT ); Thu, 13 Apr 2017 04:16:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="845349655" Date: Thu, 13 Apr 2017 11:15:55 +0300 From: Mika Westerberg To: Sven Van Asbroeck Cc: thierry.reding@gmail.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, clemens.gruber@pqgruber.com, andriy.shevchenko@linux.intel.com, Sven Van Asbroeck Subject: Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation. Message-ID: <20170413081555.GC3473@lahna.fi.intel.com> References: <1492010159-6050-1-git-send-email-svenv@arcx.com> <1492010159-6050-2-git-send-email-svenv@arcx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492010159-6050-2-git-send-email-svenv@arcx.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 11:15:59AM -0400, Sven Van Asbroeck wrote: > + pm_runtime_set_active(&client->dev); > + /* enable will put the chip into suspend, which is what we > + * want as all outputs are disabled at this point > + */ This comment should also be in the standard block comment format. Other than that, the patch looks good to me. Reviewed-by: Mika Westerberg