From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754178AbdDMONz (ORCPT ); Thu, 13 Apr 2017 10:13:55 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:47559 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752420AbdDMONw (ORCPT ); Thu, 13 Apr 2017 10:13:52 -0400 From: Colin King To: Greg Kroah-Hartman , Hans de Goede , Larry Finger , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: remove redundant comparisons of unsigned ints with >= 0 Date: Thu, 13 Apr 2017 15:13:46 +0100 Message-Id: <20170413141346.9791-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The comparison of mode >= 0 is redundant as mode is a u32 and this is always true. Remove this redundant code. Detected with CoverityScan ("Unsigned compared against 0") Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/core/rtw_debug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c index 51cef55d3f76..fc6b94d59c37 100644 --- a/drivers/staging/rtl8723bs/core/rtw_debug.c +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c @@ -1031,7 +1031,7 @@ ssize_t proc_set_ht_enable(struct file *file, const char __user *buffer, size_t if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { sscanf(tmp, "%d ", &mode); - if (pregpriv && mode >= 0 && mode < 2) { + if (pregpriv && mode < 2) { pregpriv->ht_enable = mode; printk("ht_enable =%d\n", pregpriv->ht_enable); } @@ -1150,7 +1150,7 @@ ssize_t proc_set_rx_ampdu(struct file *file, const char __user *buffer, size_t c sscanf(tmp, "%d ", &mode); - if (pregpriv && mode >= 0 && mode < 2) { + if (pregpriv && mode < 2) { pmlmeinfo->bAcceptAddbaReq = mode; DBG_871X("pmlmeinfo->bAcceptAddbaReq =%d\n", pmlmeinfo->bAcceptAddbaReq); if (mode == 0) { @@ -1191,7 +1191,7 @@ ssize_t proc_set_en_fwps(struct file *file, const char __user *buffer, size_t co if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) { sscanf(tmp, "%d ", &mode); - if (pregpriv && mode >= 0 && mode < 2) { + if (pregpriv && mode < 2) { pregpriv->check_fw_ps = mode; DBG_871X("pregpriv->check_fw_ps =%d\n", pregpriv->check_fw_ps); } -- 2.11.0