From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751510AbdDNBPc (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Apr 2017 21:15:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48094 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751083AbdDNBPa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Apr 2017 21:15:30 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 99423EEF3C
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ming.lei@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 99423EEF3C
Date: Fri, 14 Apr 2017 09:15:18 +0800
From: Ming Lei <ming.lei@redhat.com>
To: Andreas Mohr <andi@lisas.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>, Jens Axboe <axboe@fb.com>,
        Omar Sandoval <osandov@osandov.com>,
        Bart Van Assche <Bart.VanAssche@sandisk.com>,
        Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
        Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: bios with an offset are always gappy
Message-ID: <20170414011517.GB29916@ming.t460p>
References: <20170413080629.7610-1-jthumshirn@suse.de>
 <20170413100110.GB5964@ming.t460p>
 <20170413115328.GH6734@linux-x5ow.site>
 <20170413144505.GB10008@ming.t460p>
 <20170413203517.GA27520@rhlx01.hs-esslingen.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170413203517.GA27520@rhlx01.hs-esslingen.de>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 14 Apr 2017 01:15:29 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 13, 2017 at 10:35:17PM +0200, Andreas Mohr wrote:
> On Thu, Apr 13, 2017 at 10:45:10PM +0800, Ming Lei wrote:
> > +		/*
> > +		 * don't merge if the 1st bio starts with non-zero
> > +		 * offset, otherwise it is quite difficult to respect
> > +		 * sg gap limit. We work hard to merge huge of small
> > +		 * bios in case of mkfs.
> 
> "huge of small bios in case" - -ENOPARSE.
> 
> "huge numbers of"?
> "huge or small"?

OK, it should be tons of or sort of description. As you can see
in the trace, there are 2560 bios merged in one request.

Thanks,
Ming