From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbdDNJ1U (ORCPT ); Fri, 14 Apr 2017 05:27:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52296 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbdDNJ1R (ORCPT ); Fri, 14 Apr 2017 05:27:17 -0400 Date: Fri, 14 Apr 2017 11:27:05 +0200 From: Greg KH To: Vincent Legoll Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all Message-ID: <20170414092705.GA1944@kroah.com> References: <20170414090421.4281-1-vincent.legoll@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170414090421.4281-1-vincent.legoll@gmail.com> User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 14, 2017 at 11:04:21AM +0200, Vincent Legoll wrote: > No need to get into the submenu to disable all ANDROID-related config entries I don't understand this, what exactly do you mean? > > Signed-off-by: Vincent Legoll > --- > drivers/android/Kconfig | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > index a82fc02..c2b6c37 100644 > --- a/drivers/android/Kconfig > +++ b/drivers/android/Kconfig > @@ -1,15 +1,11 @@ > -menu "Android" > - > -config ANDROID > +menuconfig ANDROID > bool "Android Drivers" > ---help--- > Enable support for various drivers needed on the Android platform > > -if ANDROID > - > config ANDROID_BINDER_IPC > bool "Android Binder IPC Driver" > - depends on MMU > + depends on ANDROID && MMU > default n > ---help--- > Binder is used in Android for both communication between processes, > @@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT > earlier). > > Note that enabling this will break newer Android user-space. > - > -endif # if ANDROID > - > -endmenu There are other ANDROID config options in the kernel other than right here, so having a "menu" is a bit odd, right? thanks, greg k-h