From: Samuel Ortiz <sameo@linux.intel.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nfc: fix get_unaligned_...() misuses
Date: Mon, 17 Apr 2017 00:45:49 +0200 [thread overview]
Message-ID: <20170416224537.GB694@zurbaran.ger.intel.com> (raw)
In-Reply-To: <20170406165859.GV29622@ZenIV.linux.org.uk>
On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote:
> On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote:
> > * use unaligned.h, not unaligned/access_ok.h
>
> ... which got misspelled in that patch, sorry... Fixed variant follows:
>
> commit b3e79ba1708c9b74781079c9f8617448fce36b51
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date: Thu Apr 6 12:42:14 2017 -0400
>
> nfc: fix get_unaligned_...() misuses
>
> * use unaligned.h, not unaligned/access_ok.h
> * if a local variable of type uint16_t is unaligned, your compiler is FUBAR
> * the whole point of get_unaligned_... is to avoid memcpy + ..._to_cpu().
> Using it *after* memcpy() (into aligned object, no less) is pointless.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Partly applied to nfc-next. The unaligned/access_ok.h replacements were
already applied.
Cheers,
Samuel.
next prev parent reply other threads:[~2017-04-16 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 16:48 Al Viro
2017-04-06 16:58 ` Al Viro
2017-04-16 22:45 ` Samuel Ortiz [this message]
2017-04-07 7:01 ` kbuild test robot
2017-04-07 7:28 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170416224537.GB694@zurbaran.ger.intel.com \
--to=sameo@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®