From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932598AbdDQDLM (ORCPT ); Sun, 16 Apr 2017 23:11:12 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:40602 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932381AbdDQDLJ (ORCPT ); Sun, 16 Apr 2017 23:11:09 -0400 From: Stefan Agner To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, peter.chen@nxp.com, k.opasiak@samsung.com, yoshihiro.shimoda.uh@renesas.com, colin.king@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Agner Subject: [PATCH] usb: gadget: remove redundant self assignment Date: Sun, 16 Apr 2017 20:12:50 -0700 Message-Id: <20170417031250.407-1-stefan@agner.ch> X-Mailer: git-send-email 2.12.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The assignment ret = ret is redundant and can be removed. Signed-off-by: Stefan Agner --- A very similar patch has been applied already last year, but there is a second such assignment... -- Stefan drivers/usb/gadget/udc/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c index d685d82dcf48..b57bd53812fe 100644 --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -139,10 +139,8 @@ int usb_ep_disable(struct usb_ep *ep) goto out; ret = ep->ops->disable(ep); - if (ret) { - ret = ret; + if (ret) goto out; - } ep->enabled = false; -- 2.12.2