From: Matthias Kaehlcke <mka@chromium.org>
To: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>
Cc: user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] um: Include kbuild.h instead of duplicating its macros
Date: Mon, 17 Apr 2017 13:37:38 -0700 [thread overview]
Message-ID: <20170417203738.GQ28657@google.com> (raw)
In-Reply-To: <20170403195458.112185-1-mka@chromium.org>
El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
> index 46a9df99f3c5..7e1d35b6ad5c 100644
> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
> @@ -2,16 +2,9 @@
> #include <linux/sched.h>
> #include <linux/elf.h>
> #include <linux/crypto.h>
> +#include <linux/kbuild.h>
> #include <asm/mman.h>
>
> -#define DEFINE(sym, val) \
> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> -#define OFFSET(sym, str, mem) \
> - DEFINE(sym, offsetof(struct str, mem));
> -
> void foo(void)
> {
> #include <common-offsets.h>
> --
Ping, any comment on this patch?
Cheers
Matthias
next prev parent reply other threads:[~2017-04-17 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 19:54 Matthias Kaehlcke
2017-04-17 20:37 ` Matthias Kaehlcke [this message]
2017-04-18 7:44 ` Richard Weinberger
2017-04-18 8:17 ` Masahiro Yamada
2017-05-03 20:54 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170417203738.GQ28657@google.com \
--to=mka@chromium.org \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome