From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932636AbdDQX6h (ORCPT ); Mon, 17 Apr 2017 19:58:37 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34062 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457AbdDQX61 (ORCPT ); Mon, 17 Apr 2017 19:58:27 -0400 From: Chewie Lin To: greg@kroah.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Date: Mon, 17 Apr 2017 16:58:48 -0700 Message-Id: <20170417235848.5572-2-linsh@oregonstate.edu> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170417235848.5572-1-linsh@oregonstate.edu> References: <20170417235848.5572-1-linsh@oregonstate.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Swap string in the dev_warn() call with __func__ argument, instead of explicitly calling the function name in the string: WARNING: Prefer using "%s", __func__ to embedded function names #417: FILE: main_usb.c:417: + "usb_device_reset fail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9daf4e..71c4511b4cff 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) status = usb_reset_device(priv->usb); if (status) dev_warn(&priv->usb->dev, - "usb_device_reset fail status=%d\n", status); + "%s fail status=%d\n", __func__, status); } static void vnt_free_int_bufs(struct vnt_private *priv) -- 2.12.2