From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754720AbdDRFPe (ORCPT ); Tue, 18 Apr 2017 01:15:34 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33672 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753675AbdDRFPa (ORCPT ); Tue, 18 Apr 2017 01:15:30 -0400 Date: Tue, 18 Apr 2017 10:45:26 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Masahiro Yamada , Rob Herring , Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Viresh Kumar , Nishanth Menon , Stephen Boyd , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Mark Rutland , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Maxime Ripard , Chen-Yu Tsai , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Linux Kernel Mailing List , Vincent Guittot , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel , linux-omap@vger.kernel.org Subject: Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries Message-ID: <20170418051526.GN28191@vireshk-i7> References: <70e7c7ee13722ab9c73cb073f88502eaf1ada5f5.1491816050.git.viresh.kumar@linaro.org> <22966574.2zMrIUgKz4@aspire.rjw.lan> <6048149.VQXQ7HobDf@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6048149.VQXQ7HobDf@aspire.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-04-17, 18:40, Rafael J. Wysocki wrote: > On Monday, April 17, 2017 06:35:25 PM Rafael J. Wysocki wrote: > > On Monday, April 17, 2017 11:07:51 AM Masahiro Yamada wrote: > > > 2017-04-15 7:47 GMT+09:00 Rafael J. Wysocki : > > > > On Monday, April 10, 2017 02:51:35 PM Viresh Kumar wrote: > > > >> Compiling the DT file with W=1, DTC warns like follows: > > > >> > > > >> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a > > > >> unit name, but no reg property > > > >> > > > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a > > > >> "reg" property. > > > >> > > > >> Reported-by: Krzysztof Kozlowski > > > >> Reported-by: Masahiro Yamada > > > >> Suggested-by: Mark Rutland > > > >> Signed-off-by: Viresh Kumar > > > >> Acked-by: Maxime Ripard (sunxi) > > > >> Reviewed-by: Chanwoo Choi > > > >> Reviewed-by: Krzysztof Kozlowski > > > > > > > > OK, so any ACKs from the DT side? Rob? > > > > > > > > Thanks, > > > > Rafael > > > > > > > > > > > > I see Rob's Acked-by. > > > > > > https://lkml.org/lkml/2017/4/13/648 > > > > Indeed. Thanks! > > But it doesn't apply on top of -rc7 for me, so I guess there is new 4.12-candidate > material in the DTS tree that conflicts with this, in which case it is better to route > it through the DTS tree IMO. Yes a minor conflict. I have sent the rebased version now, see if you want to apply it directly or want arm-soc guys to do it. -- viresh