From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: jbaron@akamai.com, tglx@linutronix.de, mingo@kernel.org,
bigeasy@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp()
Date: Tue, 18 Apr 2017 12:46:29 -0400 [thread overview]
Message-ID: <20170418124629.13316f8d@gandalf.local.home> (raw)
In-Reply-To: <20170418130350.cwfij23vc4ybklkp@hirez.programming.kicks-ass.net>
On Tue, 18 Apr 2017 15:03:50 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> +++ b/kernel/padata.c
> @@ -1008,11 +1008,10 @@ static struct padata_instance *padata_al
> * parallel workers.
> *
> * @wq: workqueue to use for the allocated padata instance
> - *
> - * Must be called from a get_online_cpus() protected region
Find the comment redundant?
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> */
> struct padata_instance *padata_alloc_possible(struct workqueue_struct *wq)
> {
> + lockdep_assert_hotplug_held();
> return padata_alloc(wq, cpu_possible_mask, cpu_possible_mask);
> }
> EXPORT_SYMBOL(padata_alloc_possible);
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -561,6 +561,8 @@ int stop_machine_locked(cpu_stop_fn_t fn
> .active_cpus = cpus,
> };
>
> + lockdep_assert_hotplug_held();
> +
> if (!stop_machine_initialized) {
> /*
> * Handle the case where stop_machine() is called
next prev parent reply other threads:[~2017-04-18 16:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 10:32 [PATCH 0/3] more cpu hotplug fail Peter Zijlstra
2017-04-18 10:32 ` [PATCH 1/3] jump_label: Pull get_online_cpus() into generic code Peter Zijlstra
2017-04-20 11:29 ` [tip:smp/hotplug] " tip-bot for Peter Zijlstra (Intel)
2017-04-21 16:08 ` [PATCH 1/3] " Jason Baron
2017-04-21 16:20 ` Peter Zijlstra
2017-04-18 10:32 ` [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Peter Zijlstra
2017-04-18 13:03 ` Peter Zijlstra
2017-04-18 16:46 ` Steven Rostedt [this message]
2017-04-18 20:27 ` Peter Zijlstra
2017-04-18 20:50 ` Thomas Gleixner
2017-04-19 6:39 ` Peter Zijlstra
2017-04-19 9:08 ` Thomas Gleixner
2017-04-19 12:49 ` Steven Rostedt
2017-04-19 14:08 ` Peter Zijlstra
2017-04-19 14:21 ` Steven Rostedt
2017-04-20 11:29 ` [tip:smp/hotplug] jump_label: Provide static_key_slow_inc_cpuslocked() tip-bot for Peter Zijlstra (Intel)
2017-04-18 10:32 ` [PATCH 3/3] perf: Avoid cpu_hotplug_lock r-r recursion Peter Zijlstra
2017-04-20 11:30 ` [tip:smp/hotplug] " tip-bot for Peter Zijlstra (Intel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418124629.13316f8d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®