From: Catalin Marinas <catalin.marinas@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xen.org, jgross@suse.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
Julien Grall <julien.grall@arm.com>,
boris.ostrovsky@oracle.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."
Date: Tue, 18 Apr 2017 15:21:26 +0100 [thread overview]
Message-ID: <20170418142126.GE27592@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1492117462-19886-1-git-send-email-sstabellini@kernel.org>
On Thu, Apr 13, 2017 at 02:04:21PM -0700, Stefano Stabellini wrote:
> The following commit:
>
> commit 815dd18788fe0d41899f51b91d0560279cf16b0d
> Author: Bart Van Assche <bart.vanassche@sandisk.com>
> Date: Fri Jan 20 13:04:04 2017 -0800
>
> treewide: Consolidate get_dma_ops() implementations
>
> rearranges get_dma_ops in a way that xen_dma_ops are not returned when
> running on Xen anymore, dev->dma_ops is returned instead (see
> arch/arm/include/asm/dma-mapping.h:get_arch_dma_ops and
> include/linux/dma-mapping.h:get_dma_ops).
>
> Fix the problem by storing dev->dma_ops in dev_archdata, and setting
> dev->dma_ops to xen_dma_ops. This way, xen_dma_ops is returned naturally
> by get_dma_ops. The Xen code can retrieve the original dev->dma_ops from
> dev_archdata when needed. It also allows us to remove __generic_dma_ops
> from common headers.
>
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> Tested-by: Julien Grall <julien.grall@arm.com>
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> CC: linux@armlinux.org.uk
> CC: catalin.marinas@arm.com
> CC: will.deacon@arm.com
> CC: boris.ostrovsky@oracle.com
> CC: jgross@suse.com
> CC: Julien Grall <julien.grall@arm.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2017-04-18 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 21:04 [PATCH 1/2] xen/arm,arm64: " Stefano Stabellini
2017-04-13 21:04 ` [PATCH 2/2] xen/arm,arm64: rename __generic_dma_ops to xen_get_dma_ops Stefano Stabellini
2017-04-14 0:48 ` Boris Ostrovsky
2017-04-14 2:14 ` Konrad Rzeszutek Wilk
2017-04-18 14:21 ` Catalin Marinas [this message]
2017-04-19 17:25 ` [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..." Stefano Stabellini
2017-04-19 18:20 ` Juergen Gross
2017-04-19 18:32 ` Stefano Stabellini
2017-04-24 19:16 ` Stefano Stabellini
2017-04-25 12:51 ` Julien Grall
2017-04-25 17:22 ` Stefano Stabellini
2017-04-26 11:19 ` Catalin Marinas
2017-04-26 17:00 ` Stefano Stabellini
2017-04-26 17:13 ` Catalin Marinas
2017-04-26 17:17 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418142126.GE27592@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sstabellini@kernel.org \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®