From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760265AbdDSGj1 (ORCPT ); Wed, 19 Apr 2017 02:39:27 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59876 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835AbdDSGjZ (ORCPT ); Wed, 19 Apr 2017 02:39:25 -0400 Date: Wed, 19 Apr 2017 08:39:18 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: Steven Rostedt , jbaron@akamai.com, mingo@kernel.org, bigeasy@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp() Message-ID: <20170419063918.3z2ndmmtn2xwrb6r@hirez.programming.kicks-ass.net> References: <20170418103213.089888286@infradead.org> <20170418103422.636958338@infradead.org> <20170418130350.cwfij23vc4ybklkp@hirez.programming.kicks-ass.net> <20170418124629.13316f8d@gandalf.local.home> <20170418202708.d5xn2l5gn3mktbe5@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2017 at 10:50:43PM +0200, Thomas Gleixner wrote: > On Tue, 18 Apr 2017, Peter Zijlstra wrote: > > On Tue, Apr 18, 2017 at 12:46:29PM -0400, Steven Rostedt wrote: > > > On Tue, 18 Apr 2017 15:03:50 +0200 > > > Peter Zijlstra wrote: > > > > > > > +++ b/kernel/padata.c > > > > @@ -1008,11 +1008,10 @@ static struct padata_instance *padata_al > > > > * parallel workers. > > > > * > > > > * @wq: workqueue to use for the allocated padata instance > > > > - * > > > > - * Must be called from a get_online_cpus() protected region > > > > > > Find the comment redundant? > > > > Once there's code that enforces it? Yes. Nobody reads comments > > ;-) > > Nobody enables lockdep either ..... In the grand scheme of things, true. But there are more people running with lockdep enabled than there are people writing code, of which there are more than people reading relevant comments while writing code. Therefore having the lockdep annotation is two orders better than a comment ;-) Also, I would argue that an "assert" at the start of a function is a fairly readable 'comment' all by itself. In any case, I don't care too much. But I typically remove such comments when I stick a lockdep_assert_held() in.