From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933315AbdDSGxr (ORCPT ); Wed, 19 Apr 2017 02:53:47 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:33224 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933219AbdDSGxp (ORCPT ); Wed, 19 Apr 2017 02:53:45 -0400 Date: Wed, 19 Apr 2017 08:53:43 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH 2/3] ARM: sun8i: a83t: Drop leading zeroes from device node addresses Message-ID: <20170419065343.4lyfzf66z47tu3b4@lukather> References: <20170418042205.27894-1-wens@csie.org> <20170418042205.27894-3-wens@csie.org> <20170418090329.odixwybrkqvp2o7z@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ujsk7yzuhii2ohj6" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ujsk7yzuhii2ohj6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 18, 2017 at 05:22:02PM +0800, Chen-Yu Tsai wrote: > On Tue, Apr 18, 2017 at 5:03 PM, Maxime Ripard > wrote: > > On Tue, Apr 18, 2017 at 12:22:04PM +0800, Chen-Yu Tsai wrote: > >> Kbuild now complains about leading zeroes in the address portion of > >> device node names. > >> > >> Get rid of them. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> arch/arm/boot/dts/sun8i-a83t.dtsi | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun= 8i-a83t.dtsi > >> index 913aacafe8d5..82cb87f21b96 100644 > >> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > >> @@ -162,7 +162,7 @@ > >> #size-cells =3D <1>; > >> ranges; > >> > >> - pio: pinctrl@01c20800 { > >> + pio: pinctrl@1c20800 { > > > > As far as I know this breaks Uboot's auto-addition of stdout-path >=20 > You're right. It breaks as Uboot has the path to the uarts hard-coded. > That sucks. And from what I can tell, it's not easily solvable by just > switching to serial alias based references. CONS_INDEX won't line up > on the A23/A33 Q8 tablets. >=20 > Maybe we can just keep the uart device node the same for now, but fix > all the other ones. We can come back and fix the uart later once we > figure out how to fix Uboot. Thinking more about this, I don't really know why we have that in U-Boot actually. All our DTs for a very long time have had stdout-path properly set (and if it's improperly set, this should be fixed). I'd say we can simply remove that from U-Boot and be done with it. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --ujsk7yzuhii2ohj6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJY9wl3AAoJEBx+YmzsjxAgz60P/RgBPFOIsCLUkkvlHP5tkhg3 PZtohnclcmvEoPFUqHr6bCsc/85Vym8BoZWVEYi74Wei3IsEl+bkArRxZEOIwg0p DnNU2Vh+IYtREgBkofus3PJdIa19/sbFZzBnGUbxBxV3ATSb53uqJuTPIKM5gA0y PxslpxZ3Mh8589Mfq1U5jFakfAP8q1L6wErTbfHc8mLhC0oFB+MX0agN3Rc9e6+r Z3wPQwCZWuxSvFY+Yk18C5yJ+6xEBg4r6jfgB8IFSxW6/lXDeIL2uq8LnJHLyX8m C1A2RgZHCkS1zwS4pJMkaziDSt8gDWmTz3MAq0Q/3Eq/PSmlAtvg88cwSXr4A4Lp U9Qbuvukl7ZCV+54aRmCJczZpz71S06XBIYUZiOrQ+Lx6RCvJ2cvgLTzfGzEaDJf Cr8tfCEc760LSJYBbtCzXKYdsRa/o9VHLmVF9pOVtVJrLERd77Dyw2blz7IClkSG 9rw9FjI7+bGiNRC8eW51mh+byrXSfYJ5Cz0XUfcwkT8VmW8FjOHFciHazstt3vIz UNoDp/O5oVS/zTdRUFzDh7mYeVbY9chMPsrNsqJLvEtU2EnnnBsWRbO+J9re2T3X w3ai7iOkE+N7B1wM/HkPGX36mye/sc3v53TubW37RBecX9qmYtKl8mdBtxK1kzD9 OtSxvaBFjUe0vkFySkFP =KRzU -----END PGP SIGNATURE----- --ujsk7yzuhii2ohj6--