From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760462AbdDSHYV (ORCPT ); Wed, 19 Apr 2017 03:24:21 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:52592 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759291AbdDSHYQ (ORCPT ); Wed, 19 Apr 2017 03:24:16 -0400 Date: Wed, 19 Apr 2017 09:24:11 +0200 From: Peter Zijlstra To: Thomas Gleixner Cc: LKML , John Stultz , Eric Dumazet , Anna-Maria Gleixner , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Arjan van de Ven , "Paul E. McKenney" , Frederic Weisbecker , Rik van Riel Subject: Re: [patch V2 08/10] timer: Implement the hierarchical pull model Message-ID: <20170419072411.uxd7spyzgs5oszah@hirez.programming.kicks-ass.net> References: <20170418111102.490432548@linutronix.de> <20170418111401.016420305@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170418111401.016420305@linutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2017 at 01:11:10PM +0200, Thomas Gleixner wrote: > @@ -1689,11 +1708,16 @@ static void run_timer_base(int index, bo > */ > static __latent_entropy void run_timer_softirq(struct softirq_action *h) > { > + struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_LOCAL]); Does this want to be inside the IS_ENABLED() block below? It seems to me this could generate an unused variable warning for !NO_HZ_COMMON compiler. > + > run_timer_base(BASE_LOCAL, false); > > if (IS_ENABLED(CONFIG_NO_HZ_COMMON)) { > run_timer_base(BASE_GLOBAL, false); > run_timer_base(BASE_DEF, true); > + > + if (base->nohz_active) > + tmigr_handle_remote(); > } > }