From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760794AbdDSID6 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Apr 2017 04:03:58 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:33219 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750849AbdDSIC6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Apr 2017 04:02:58 -0400
Date: Wed, 19 Apr 2017 10:02:54 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        the arch/x86 maintainers <x86@kernel.org>, wanpeng.li@hotmail.com,
        Andrew Morton <akpm@linux-foundation.org>,
        hidehiro.kawai.ez@hitachi.com, LKML <linux-kernel@vger.kernel.org>,
        Fengtiantian <fengtiantian@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>
Subject: Re: [PATCH V4] x86: call smp vmxoff in smp stop
Message-ID: <20170419080254.c3j5lwztad2fswwr@gmail.com>
References: <586CCA5A.8050607@huawei.com>
 <586DA529.1040803@huawei.com>
 <58798201.2@huawei.com>
 <587F523B.80301@huawei.com>
 <3d5bf4c2-7415-a976-62fb-ba653f92eada@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3d5bf4c2-7415-a976-62fb-ba653f92eada@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Paolo Bonzini <pbonzini@redhat.com> wrote:

> Ingo, can you put this in tip?
> 
> Thanks,
> 
> Paolo
> 
> On 18/01/2017 12:32, Xishi Qiu wrote:
> > From: Tiantian Feng <fengtiantian@huawei.com>
> > 
> > We need to disable VMX on all CPUs before stop cpu when OS panic,
> > otherwisewe risk hanging up the machine, because the CPU ignore INIT
> > signals when VMX is enabled. In kernel mainline this issue existence.

Yes, but the changelog is atrcious:

 - title should describe the purpose, not the implementation

 - CPU is spelled 'CPU' once, then 'cpu' _in the same sentence_!

 - typos

 - spelling

 - the last sentence doesn't even parse ...

Still it's already at V4 and comes with two signoffs and what amounts to a 
maintainer Ack??

Thanks,

	Ingo