From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1764313AbdDSOVs (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Apr 2017 10:21:48 -0400
Received: from mail.kernel.org ([198.145.29.136]:47284 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1761796AbdDSOVo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Apr 2017 10:21:44 -0400
Date: Wed, 19 Apr 2017 10:21:38 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, jbaron@akamai.com,
        mingo@kernel.org, bigeasy@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp()
Message-ID: <20170419102138.7442c56d@gandalf.local.home>
In-Reply-To: <20170419140804.xsv4zsj5cm7ghrtc@hirez.programming.kicks-ass.net>
References: <20170418103213.089888286@infradead.org>
        <20170418103422.636958338@infradead.org>
        <20170418130350.cwfij23vc4ybklkp@hirez.programming.kicks-ass.net>
        <20170418124629.13316f8d@gandalf.local.home>
        <20170418202708.d5xn2l5gn3mktbe5@hirez.programming.kicks-ass.net>
        <alpine.DEB.2.20.1704182250180.8081@nanos>
        <20170419063918.3z2ndmmtn2xwrb6r@hirez.programming.kicks-ass.net>
        <alpine.DEB.2.20.1704191107170.1829@nanos>
        <20170419084911.61e0e965@gandalf.local.home>
        <20170419140804.xsv4zsj5cm7ghrtc@hirez.programming.kicks-ass.net>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 19 Apr 2017 16:08:04 +0200
Peter Zijlstra <peterz@infradead.org> wrote:


> Yeah, rainbows and unicorns are shiny. Also, I put kerneldoc (if I put
> it at all) at the definition site, not the declaration. So headers are
> useless.

What's wrong with rainbows and unicorns. We all have our ponys, and
some of them are unicorns.

https://www.slideshare.net/brendangregg/velocity-2015-linux-perf-tools/105

> 
> 
> In any case, I don't mind the extra line of comment. Don't really see
> the point of it either. What I am convinced of is that
> lockdep_assert_held() lines are far more useful than such comment lines.

I agree with the lockdep assert held being more useful. But I disagree
with removing comments about required locks when it is added. A comment
may save a developer an embarrassing moment of being yelled at because
they didn't test their code with lockdep enabled. And that is useful.

-- Steve