From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968503AbdDSRdT (ORCPT ); Wed, 19 Apr 2017 13:33:19 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:59131 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965500AbdDSRdQ (ORCPT ); Wed, 19 Apr 2017 13:33:16 -0400 From: Arnd Bergmann To: Marcel Holtmann , Alexander Aring , Stefan Schmidt Cc: Arnd Bergmann , Harry Morris , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ieee802154: don't select COMMON_CLK Date: Wed, 19 Apr 2017 19:32:25 +0200 Message-Id: <20170419173233.3726121-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:nCtp6dKf+N0wDPI8AYC6sMuYtZcJ3mkBoQ0R0baE8NZDsZNGV1N 0NZo5OpmAuzZFGOZT0BYy7DS2bmKGYQTHgG3i9767lEr/fjuRNt5Xo9D24WNMaWKUvrdieh wmzW1qcWjFb2EkzO/QKDxcyLPnihTLqE9u/8oqBuzN1bJiev7WLBSnIwl/gT8R3xLsUrl6C VnDL/0mQgOUzdgr7QveuQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:hJQNe8Cp36s=:9/uVfkbh00F/3qjPUrEwcX v9HP/Bv4YY6aiKo/4Zy7KOTMkVbcRoQT3LNa8GAiBXQ3ftW3SgSMyBTiqGgB55JCJw7hStZNE CE9FqnxDfdRVnovMtA9Mp+ydpl9BVlZOsAkmnKy4XBivQwYDKLKwq0Q2CfQSs5Z2bCWce6fvI g275mbajJDxH6OCIVboQ7LOxcVChQZfAnlfKdYmGTgT0Rc9X9D9PuExGokW+6u5uP0RBnS7iy +cazejc8b9a/03j/Odt6MctqvIYMoWGIVP/yknKRqQ+DHbXr429x1ZOtTibi6kHnIKVcaKUPm BAfV/PZt0AyxWvfMqFMAptOVc5OWvZhNQbUBtNVWjcTxL8t+Avsg2Og8LqEx663oxxashZ4qb Rq21iANJdGucAJdGP0BkFMrl7/qE12YZcs0UCy5eKRTGQXSofWe7kQalJRbWYHw3kLv8zuV2z PMYOPAmGd1MCPtlqaoqp9olSmnen1PUjDlqrdjKmoVGqcfMhr/C1csnwWAeCBJHlurETj2iW8 Ty75MCcJB6bQgTgpAlHHkNsr+koLtX8SAmI6pGazmoUJm0EoKBlr0sREAUtRTKk4u/G+HqYWq HgR/H8+MzSDL0C2TDjFTbdHyHdfdSqMB0sp94HIf/kMXna05Ford5IcMAg0xUfZiKdraWohxY 2aAqepjT4mrYIZol7XWmIjqnz/jw1xLKtCf3+7R3KRTF18bBGoOJa7NNPIXz/HmUanQo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A device driver must not select the COMMON_CLK subsystem, as that conflicts with platforms that provide a legacy implementation of the clk API: drivers/clk/clk.o: In function `clk_enable': clk.c:(.text.clk_enable+0x0): multiple definition of `clk_enable' arch/arm/mach-sa1100/clock.o:clock.c:(.text.clk_enable+0x0): first defined here drivers/clk/clk.o: In function `clk_round_rate': clk.c:(.text.clk_round_rate+0x0): multiple definition of `clk_round_rate' arch/arm/mach-sa1100/clock.o:clock.c:(.text.clk_round_rate+0x0): first defined here drivers/clk/clk.o: In function `clk_get_parent': clk.c:(.text.clk_get_parent+0x0): multiple definition of `clk_get_parent' arch/arm/mach-sa1100/clock.o:clock.c:(.text.clk_get_parent+0x0): first defined here drivers/clk/clk.o: In function `clk_get_rate': clk.c:(.text.clk_get_rate+0x0): multiple definition of `clk_get_rate' This changes the 'select' into 'depends on', as all other similar drivers do. Fixes: d931acd575d6 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Signed-off-by: Arnd Bergmann --- drivers/net/ieee802154/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/Kconfig b/drivers/net/ieee802154/Kconfig index ce4864dc3c6e..303ba4133920 100644 --- a/drivers/net/ieee802154/Kconfig +++ b/drivers/net/ieee802154/Kconfig @@ -86,8 +86,8 @@ config IEEE802154_ADF7242 config IEEE802154_CA8210 tristate "Cascoda CA8210 transceiver driver" depends on IEEE802154_DRIVERS && MAC802154 + depends on COMMON_CLK depends on SPI - select COMMON_CLK ---help--- Say Y here to enable the CA8210 SPI 802.15.4 wireless controller. -- 2.9.0