From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033653AbdDTR4U (ORCPT ); Thu, 20 Apr 2017 13:56:20 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:51125 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033635AbdDTR4P (ORCPT ); Thu, 20 Apr 2017 13:56:15 -0400 From: Arnd Bergmann To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , stable@vger.kernel.org, Johannes Berg , Quentin Lambert , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] scsi: pmcraid: fix lock imbalance in pmcraid_reset_reload() Date: Thu, 20 Apr 2017 19:54:46 +0200 Message-Id: <20170420175549.3435196-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170420175549.3435196-1-arnd@arndb.de> References: <20170420175549.3435196-1-arnd@arndb.de> X-Provags-ID: V03:K0:X6xvQk/eT128S/b4K/IJtILelyzBk8JEA5SZvtKNPHWpM6tBhCW pVZLy+B2X0S49NKagIiKsHg//jnfKSk/WpuMUCUckFzsLXC9fHqSOLS5HSTL8FlwEWNH+lI CvvM57SkO9dMzAHGsVLwuhJ4jWSq/H1rpA1hpkIlfV5F6PdhgtbncRNy5Dz+MuvZ5geNhMG 56tNnf1onWpNwEkCNJJzA== X-UI-Out-Filterresults: notjunk:1;V01:K0:+DnUjT1gVaM=:jBcDF+6Z4IBJrOPsiKu8IR hNilG1GD6duebZZZFxsygkB7caB7xAn3TCSZJiJptncA1Ot1FcACed04gA7Bkz4v66mYrMqip 0AJ53iLHzplW0SvxTrYMQeWokGEMBjCIsu0GH7gbpjRilJBSU5nV6JCN66qhy7kodAbmTxgw9 dySg7Y/uMNbeP3ZkbHBzmn2u9i8p64PGO5KnrtYENL2aNU7ut4W0xiXDhYx54Y4yEzFAm0psh oe3xPdTT7enUHTAWXfRUkyov0x8+8mHQva7i3ervQo8PZUIYelwbyCAdRxIAeP21YDz5XObQ3 yKgbqyqwUx8TEUZ2QmHJyUDio22/Yj9hLGYtTdyGOicuzfbHOVwh7XEHjeNZQLm0af6Q1vPEt 3ZlTNjt9DNRBHoVsxLEiGlm5SwBRtzAYkDWD0f1KJdvcaG4okFG4DWmm69Q4Kya8NuftMBwL3 2SHarZmUykBW4Cm7PUuLQcjBTMWJb5Nhu2+zkURR4oYjhPwDf2/gDxfqPvjeavzxDtluqTbgy /Tx88xENpCejNuPd1KwlX6UtYswXEZT4sbJsmPYxth2jdbIBkRcYYzG1xJBhJHuhFzUpMs9fK c4i/kPeaGGG76uMvaqn3Z0jgZ38ePGn4Hp022QVBc+q/pwa3DX2TaZ1R/3wgX20VSQiw5rR/t RTKchePAFgYHHLw5MTXwBNY3Aff4dV8zDmA+1XwsHNTF64SheocHswqaYQewNfYCToZw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sparse found a bug that has always been present since the driver was merged: drivers/scsi/pmcraid.c:2353:12: warning: context imbalance in 'pmcraid_reset_reload' - different lock contexts for basic block This adds the missing unlock at the end of the function. I could not figure out if this will happen in practice, but I could not prove that it doesn't happen, so to be on the safe side, let's backport this fix. Cc: stable@vger.kernel.org Fixes: 89a368104150 ("[SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller") Signed-off-by: Arnd Bergmann --- drivers/scsi/pmcraid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index 096c704ca39a..35087e94c2ad 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -2411,8 +2411,11 @@ static int pmcraid_reset_reload( scsi_unblock_requests(pinstance->host); if (pinstance->ioa_state == target_state) reset = 0; + spin_lock_irqsave(pinstance->host->host_lock, lock_flags); } + spin_unlock_irqrestore(pinstance->host->host_lock, lock_flags); + return reset; } -- 2.9.0