From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1038158AbdDUKwY (ORCPT ); Fri, 21 Apr 2017 06:52:24 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:49921 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1038048AbdDUKwW (ORCPT ); Fri, 21 Apr 2017 06:52:22 -0400 From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: Arnd Bergmann , Benjamin Gaignard , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] cec: improve MEDIA_CEC_RC dependencies Date: Fri, 21 Apr 2017 12:52:17 +0200 Message-Id: <20170421105224.899350-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:fZT8sE6cOPF5anEfGg8RvG4BgNAbsbltBNEpJLNbJczJdg/Db8R Z7bk8ejdOwnZ2CLsukmWUmX4jWT3kmJVNw5+gOXCnQsPa62rbY51oBfa+EKjPP83fKcR2CK Rx1vG3ATffc+xmWXFiYE47NMK1UZBPgP/f11KSq85kC2LrptxtJGbKUK7Cc8bI82s/zSFMz QbVURpPJtmRG36auEEKPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:SvaYQit+gr0=:k38brep+8M8JoZ2Yqag772 Ot5550fCgJJJ/61x1iG8ffilIvYJiGvuczG5wsj8uAC9OLVzdqndV47dBI81HT7vADFO++sRX 54Biby+83As78fqjlTLtptNsN+LERibJTAhfWoRZNuEA2uzEh6AclYg20bCROmokP+l4U25PO eSZQ/DV/If+zFDOZQYnQHGRZY35M4dbGwi+W+wkL1cIw72X6IJKJyyE933dZ3QwNpNXvGLmob if56It+WcsWaL9H2QZryxeIofOs3aUo9lgDA/OG/ph25Xu9I9SpP45LQb0hs3cURUq758hfRI AK8iXkUJViyvN9dweeagMQ4PpK3fUy8Fel0o59SizKFOIlE/dX4B+Kr7IRYdyBA5rM0RIvmOE NWe5HzqVBO3EdSGuQMrf3m598CrG7n2FimWQncZuOp+sqlrsJodaXMChPBP5MibPwy4lqomts WbH/oM7+sa/PgQ04pOlvi+5dZdFAt5kEhYWW1n4X0F7rzjrjO36r1uMdF95Hxx64qPx6rnISu QVnv3YAhA0MVezTQppYtl6S/E6kvDy+iCcH+rXJ8yDxd/m8hJEIYdJQL03CFx0nqMTnh5JG19 6fRZcT3UJqKJDQc9PjwgeCc9wjLoGpd4cj/5wylyYe0FtRCy1TxqlZkN4rNdI0PB4ggmh9NGT pOHeeQCLyWE42vVv9QQojUsDqgas1NoemrodJRsLrIuVz+ewAu+/nZntSI+ZDRL5gf3I= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changing the IS_REACHABLE() into a plain #ifdef broke the case of CONFIG_MEDIA_RC=m && CONFIG_MEDIA_CEC=y: drivers/media/cec/cec-core.o: In function `cec_unregister_adapter': cec-core.c:(.text.cec_unregister_adapter+0x18): undefined reference to `rc_unregister_device' drivers/media/cec/cec-core.o: In function `cec_delete_adapter': cec-core.c:(.text.cec_delete_adapter+0x54): undefined reference to `rc_free_device' drivers/media/cec/cec-core.o: In function `cec_register_adapter': cec-core.c:(.text.cec_register_adapter+0x94): undefined reference to `rc_register_device' cec-core.c:(.text.cec_register_adapter+0xa4): undefined reference to `rc_free_device' cec-core.c:(.text.cec_register_adapter+0x110): undefined reference to `rc_unregister_device' drivers/media/cec/cec-core.o: In function `cec_allocate_adapter': cec-core.c:(.text.cec_allocate_adapter+0x234): undefined reference to `rc_allocate_device' drivers/media/cec/cec-adap.o: In function `cec_received_msg': cec-adap.c:(.text.cec_received_msg+0x734): undefined reference to `rc_keydown' cec-adap.c:(.text.cec_received_msg+0x768): undefined reference to `rc_keyup' This adds an additional dependency to explicitly forbid this combination. Fixes: 5f2c467c54f5 ("[media] cec: add MEDIA_CEC_RC config option") Signed-off-by: Arnd Bergmann --- drivers/media/cec/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/cec/Kconfig b/drivers/media/cec/Kconfig index f944d93e3167..488fb908244d 100644 --- a/drivers/media/cec/Kconfig +++ b/drivers/media/cec/Kconfig @@ -9,6 +9,7 @@ config MEDIA_CEC_NOTIFIER config MEDIA_CEC_RC bool "HDMI CEC RC integration" depends on CEC_CORE && RC_CORE + depends on CEC_CORE=m || RC_CORE=y ---help--- Pass on CEC remote control messages to the RC framework. -- 2.9.0