From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1039546AbdDUNHN (ORCPT ); Fri, 21 Apr 2017 09:07:13 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59439 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1039196AbdDUNHM (ORCPT ); Fri, 21 Apr 2017 09:07:12 -0400 From: Arnd Bergmann To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, Arnd Bergmann , Felipe Balbi , Bin Liu , Sasha Levin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH, 3.18-stable regression] gadgetfs: fix uninitialized variable in error handling Date: Fri, 21 Apr 2017 15:06:12 +0200 Message-Id: <20170421130623.2668561-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:M/7Z+inRzN8kWnbQJjwYrlWRP1tsnQho/4VkR9NdgU0wgou2SZR uUbZisyvP5WdLitnQQz4gqTYR13B36ozhc5g4O/iaGSPCXXVWbF1ffmqZJzq4P1IVHDF30x qOM7tKGIYf0ewAm9OMwSq8J9esmpe5C5UAWa3lHEtdMITs52H3iywec1obzuctWNInNbHdG rwTTct9hhaRnySTw4zn1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:9jnFpXCB1qA=:qjHDwQk4RL7ZPSKS1x+SNA xKFUcYfGHr+/Hl6UdHowTeBj0J0+VLc5NDIU0+dOuX7gA4oo2XIo69qeGuVUOXzd9c2oEvHSq tzTcyzqoRjOMu+IDnvKunwVXy4A4KHtJJZ1UPuod5no5R5+qSXlVnvVi70/CydczbicUkFoIF T9P3D2WdqtOgwDZKjRHeFHEXJVNyMwfH6MeiMhTKmxj2GwZ9/FHF+chkgQRI/gx71uCZK7dGu MlhGX8KJeXvrp58iJzwCUvRbEmdUkc0FHRO7C9SzJYhzSPATNe6Ja7xnUSIYllOzCI9sHOrQK NZYI4Jn7A0HYIW3ihVggV6Q6wvovvNsITPGaZVmEPlauL/Bm3Zr8EHkONMf0S4VGoOmARoDAO ZAuFso63qiajmoXXZyCrYBa56elOYH90o+3CPP1/c9PdBknbJLnVpjaFEIHCHhtPpYzPmyZNO J7s401qduHBwwBwjOgHxEgpY6kB74qgq7gMYLn/VL6r3xbajVhyFLSYJNtEgpamwpeNeUU1iz t4a/uaGUG2WzM2+tsBBOO12yR2Vu8v1WHfmmesVVAigoS0EmYJImHHZRemKQ1Q4grwKAAkabA d1BQISYH3fbT7AyPFB9NmHoM7AotlCGYZmPuEEyyNjKYqNlT1ZUbse0PoiAEo7Oyb2D1iclxR gyht3NiH7ar2sbjdGC7RfYnoZHUh1o+JN8KgT3YrH2YBS5fVSZQ3B8WZAr0qYpXrQScU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc warns about a bug in 3.18.y: drivers/usb/gadget/legacy/inode.c:648:10: warning: 'value' may be used This is caused by the backport of f01d35a15fa0416 from 4.0 to 3.18: c81fc59be42c6e0 gadgetfs: use-after-free in ->aio_read() The backported patch was buggy, but the mainline code was rewritten in a larger patch directly following this one in a way that fixed the bug. For stable, we should need only a one-line change to make sure we return an proper error code. It is very unlikely that anybody ever ran into the out-of-memory case here in practice, but the compiler is right in theory. Fixes: c81fc59be42c ("gadgetfs: use-after-free in ->aio_read()") Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 54f964bbc79a..fe45311f243e 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -654,6 +654,7 @@ fail: GFP_KERNEL); if (!priv->iv) { kfree(priv); + value = -ENOMEM; goto fail; } } -- 2.9.0