From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1040090AbdDUNmQ (ORCPT ); Fri, 21 Apr 2017 09:42:16 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:63599 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035492AbdDUNmN (ORCPT ); Fri, 21 Apr 2017 09:42:13 -0400 From: Arnd Bergmann To: stable@vger.kernel.org Cc: gregkh@linuxfoundation.org, Arnd Bergmann , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3.18-stable] dm bufio: hide bogus warning Date: Fri, 21 Apr 2017 15:41:10 +0200 Message-Id: <20170421134212.2727744-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:JDZSUrwH4Wfu2zBXA0x8grxGIjyCYiFOkrwl+yGi/TC3O22s9Uo jpfKwJFGuUt/7eDeL+XsewrFHo+5wF3geIXrt7n3xB0TF6hR4Iwqd6T/rZclbMlyFw+sQby MmjTHTLvUyix6ocear208eawGeKd2CbhpMIKCBgCFGMXbMdLDRLitxP8igtASwZ81vKrbUh h+geVrxyTUwnbfB0tSl0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:9JJZFIUypvU=:oqPVfuwIlFJG2uM5K8GkBh 0zqOf8eEbewCBwzIGa1bcPueFOMBXQ9LsGjlY4Z2F1/XKu4UlLmuBxlWL9f4Yc8H+glz9DFk5 3EbB+p//ZWgGnzyKXkvQS5R84dYy7W5PWEmUYgHn3KfYTBI4GsB7mvH+ePcu095HDTVfDTqBe /Z4Lla7nFybKN6oaiODh8N00RX5pko5uB4cGZ135Hn8Rtsar/fgBqTJeD2H7uhLekQvGAIsak uNk9ZEGpj1gJV3aelQWHaVm8i9UoPm1rtFxXF7yvqsPrpsTGTAosjvDyDvtETQ9eLAT9Hc7kl BZdK8dHqJ2UqHPD8OrsgOCh0P99BNXc7Yz8JFpaBJZOvfpX0OXPmpvKrqy+5BMfBoP+hRaMx2 kLTniGNhlZKc2IY8QAr6HRbAZexJsBMnQAafeIQfqyN5a/Q/idBlKIEvqQiN0BXfrBZSkfi4g PKCEGE4keh2vIGFoWVqcey5zd/X1ahuTqgOVs84UKCONfsDh+T6j2azSnzYfEbx82Enep68wF tRwfbv15ZC/hFX9kG9vQObTxl1PDDhgqQk1R1kRYxoSiwJwrebIn6fkPC+ljxmkA66DmXyHHW soyOsHNLD9THXwxdSW+fozDBUrc9WvJM3ThHXepb7OyyqsRCaAXhMFEPsYZmiy2MRudALLT8x YfCNCLb/Zk8wu+EW8rYhYwNBCFN34RWZJS8D+X1uint04UcOGb/VEbCvZoD1Jop7T6zs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mips-gcc-5.3 warns about correct code on linux-3.18 and earlier: In file included from ../include/linux/blkdev.h:4:0, from ../drivers/md/dm-bufio.h:12, from ../drivers/md/dm-bufio.c:9: ../drivers/md/dm-bufio.c: In function 'alloc_buffer': ../include/linux/sched.h:1975:56: warning: 'noio_flag' may be used uninitialized in this function [-Wmaybe-uninitialized] current->flags = (current->flags & ~PF_MEMALLOC_NOIO) | flags; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../drivers/md/dm-bufio.c:325:11: note: 'noio_flag' was declared here The warning disappeared on later kernels with this commit: be0c37c985ed ("MIPS: Rearrange PTE bits into fixed positions.") I assume this only happened because it changed some inlining decisions. On 3.18.y, we can shut up the warning by adding an extra initialization. Signed-off-by: Arnd Bergmann --- drivers/md/dm-bufio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c index ecbd3ffcf359..91fe43b98c96 100644 --- a/drivers/md/dm-bufio.c +++ b/drivers/md/dm-bufio.c @@ -349,6 +349,7 @@ static void *alloc_buffer_data(struct dm_bufio_client *c, gfp_t gfp_mask, * as if GFP_NOIO was specified. */ + noio_flag = 0; if (gfp_mask & __GFP_NORETRY) noio_flag = memalloc_noio_save(); -- 2.9.0