From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422819AbdDURIH (ORCPT ); Fri, 21 Apr 2017 13:08:07 -0400 Received: from merlin.infradead.org ([205.233.59.134]:40866 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422761AbdDURHm (ORCPT ); Fri, 21 Apr 2017 13:07:42 -0400 Date: Fri, 21 Apr 2017 18:20:31 +0200 From: Peter Zijlstra To: Jason Baron Cc: rostedt@goodmis.org, tglx@linutronix.de, mingo@kernel.org, bigeasy@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] jump_label: Pull get_online_cpus() into generic code Message-ID: <20170421162031.awoyiz3k6dltnnch@hirez.programming.kicks-ass.net> References: <20170418103213.089888286@infradead.org> <20170418103422.590118425@infradead.org> <2bc2af64-e014-b56a-4a01-d8d9ea732504@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bc2af64-e014-b56a-4a01-d8d9ea732504@akamai.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2017 at 12:08:26PM -0400, Jason Baron wrote: > On 04/18/2017 06:32 AM, Peter Zijlstra wrote: > > @@ -146,6 +154,7 @@ static void __static_key_slow_dec(struct > > * returns is unbalanced, because all other static_key_slow_inc() > > * instances block while the update is in progress. > > */ > > + get_online_cpus(); > > if (!atomic_dec_and_mutex_lock(&key->enabled, &jump_label_mutex)) { > > WARN(atomic_read(&key->enabled) < 0, > > "jump label: negative count!\n"); > > So the get and put can be unbalanced here since the above: > > 'if (!atomic_dec_and_mutex_lock(&key->enabled, &jump_label_mutex))' > > is followed by 'return;'. However, I see that the next patch removes this > and so things are balanced again... Duh.. right you are. > > @@ -159,6 +168,7 @@ static void __static_key_slow_dec(struct > > jump_label_update(key); > > } > > jump_label_unlock(); > > + put_online_cpus(); > > } > > > > static void jump_label_update_timeout(struct work_struct *work) > > @@ -592,6 +602,10 @@ jump_label_module_notify(struct notifier > > > > switch (val) { > > case MODULE_STATE_COMING: > > + /* > > + * XXX do we need get_online_cpus() ? the module isn't > > + * executable yet, so nothing should be looking at our code. > > + */ > > Since we're just updating the table of places we potentially need to patch, > but not actually doing any patching, we should not need get_online_cpus() > here...so in attempt to reduce confusion I would remove this. Thanks for confirming it is indeed not required. Will make it go away.