From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423531AbdDUSV0 (ORCPT ); Fri, 21 Apr 2017 14:21:26 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60506 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423499AbdDUSVF (ORCPT ); Fri, 21 Apr 2017 14:21:05 -0400 From: Arnd Bergmann To: Andrew Lunn , Vivien Didelot , Florian Fainelli Cc: Arnd Bergmann , "David S. Miller" , Rob Herring , Juergen Beisert , Sean Wang , John Crispin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: dsa: LAN9303: add I2C dependency Date: Fri, 21 Apr 2017 18:22:40 +0200 Message-Id: <20170421162259.3312997-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:pqAydOcdlhDwIePJ2Xo2qamj7Ra2+b/UTWWgHXnfemAUc7+eCDA EQXIOx2+rpVO/Avy7+cVuwT+N7w8wWkkYdnpDwOGWayb8EOalczxpqeOxzG7LGJiN3O4bxB JPzidRXRq5GfJtpe0dCobAL2I6KIsj3UFwDRX6NYFYsae+VqN+gpBuHQrKjeCUnb6jrZKCV Udv+zfpVPrhD9PL4C3+dQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:KKp3KmFuo08=:rn33gk1fvTaX/jSIA8hUzq gF5ZTwm0OKQ0vnU6pGlvnWPY5iC/MaxMsggC9+uH2hpFycJLrpTn3mYCEbaNU4x4A2qcLJYF4 km4mQACnn6k0/C89Ahb3ob01NAmvO8YHKl6qUC95EyvgPeOnCcGxU7WH65CgAWyVzsMPj5tb3 Mia+W4oufQaS3j3I01dpK47yuQpNsezRRL4eTlWoLgnddqTMxNTsd7HDR3RfepaGZf4128zp8 7+waug0/KTXTp/85X2bfiB3jerWQ043nKHCle4mQRlCVo1h/GIR5y2B3tQTtsizpVABVyTjfE uq7g3ZFCd6MJfjhK0BmxjbIgbsqASV9Z6PKGOoU1XJnGOJ6KQR26I8vuWqPGSGyvnHwhsWTaC G/pawpCd+Jtgf5QkoGz41+aq+T9J/uLXvW3wo1odvAdmX+WAARl9uq02NBGO7/Mp2T+OSeDIA GD9Spl6q3X6EnqYmgwgJWdSdb9V6mtxOdgK90/rceuG/xobBoWSqHdGk245HU/v+fNbtOiZl3 zumqD6kUgOv8RrwURxL/hx7bDX/CJM9Cc91gzdwgOv9rYfhEvxsaBLI5yM+wPc2W5YdVC4Zl1 KgQHF+FCIr5pDLxAQJORr9eiTsfTuiLeyZ1HElmiYPO2jIrOcBbW2gZ72iFbNoaCZQ78R4LcJ hBuF9WfCuoM3S933+ZNbpOLV7ipMiTt9EmhNUWY08BsXDXbeJbsxh3srnDjybWkGxCvI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With CONFIG_I2C=m and NET_DSA_SMSC_LAN9303=y, we run into a link error: drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_byte_reg_read': regmap-i2c.c:(.text.regmap_smbus_byte_reg_read+0x18): undefined reference to `i2c_smbus_read_byte_data' drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_byte_reg_write': regmap-i2c.c:(.text.regmap_smbus_byte_reg_write+0x18): undefined reference to `i2c_smbus_write_byte_data' drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_word_reg_read': regmap-i2c.c:(.text.regmap_smbus_word_reg_read+0x18): undefined reference to `i2c_smbus_read_word_data' drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_word_read_swapped': regmap-i2c.c:(.text.regmap_smbus_word_read_swapped+0x18): undefined reference to `i2c_smbus_read_word_data' drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_word_write_swapped': This adds a Kconfig dependency to avoid the broken configuration. Fixes: be4e119f9914 ("net: dsa: LAN9303: add I2C managed mode support") Signed-off-by: Arnd Bergmann --- drivers/net/dsa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index 131a5b1cbfc8..862ee22303c2 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -59,7 +59,7 @@ config NET_DSA_SMSC_LAN9303 config NET_DSA_SMSC_LAN9303_I2C tristate "SMSC/Microchip LAN9303 3-ports 10/100 ethernet switch in I2C managed mode" - depends on NET_DSA + depends on NET_DSA && I2C select NET_DSA_SMSC_LAN9303 select REGMAP_I2C ---help--- -- 2.9.0