From: David Miller <davem@davemloft.net>
To: fengguang.wu@intel.com
Cc: sudarsana.kalluru@cavium.com, kbuild-all@01.org,
netdev@vger.kernel.org, Yuval.Mintz@cavium.com,
Ariel.Elior@cavium.com, everest-linux-l2@cavium.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: fix kzalloc-simple.cocci warnings
Date: Mon, 24 Apr 2017 12:03:27 -0400 (EDT) [thread overview]
Message-ID: <20170424.120327.187268095994980448.davem@davemloft.net> (raw)
In-Reply-To: <20170421002007.GA8379@lkp-sbx04>
From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 21 Apr 2017 08:20:07 +0800
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1267:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset
>
>
> Use kzalloc rather than kmalloc followed by memset with 0
>
> This considers some simple cases that are common and easy to validate
> Note in particular that there are no ...s in the rule, so all of the
> matched code has to be contiguous
>
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
> CC: sudarsana.kalluru@cavium.com <sudarsana.kalluru@cavium.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
I intentionally let this change happen.
It was less risky than asking the submitter who introduced it to
make another respin to keep the kzalloc().
next prev parent reply other threads:[~2017-04-24 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201704210853.tUPLU4Mh%fengguang.wu@intel.com>
2017-04-21 0:20 ` kbuild test robot
2017-04-24 16:03 ` David Miller [this message]
[not found] <201609011409.GGSqCknq%fengguang.wu@intel.com>
2016-09-01 6:45 ` kbuild test robot
2016-09-01 7:37 ` Yuval Mintz
2016-09-01 16:48 ` David Miller
2016-09-02 17:44 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424.120327.187268095994980448.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ariel.Elior@cavium.com \
--cc=Yuval.Mintz@cavium.com \
--cc=everest-linux-l2@cavium.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sudarsana.kalluru@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®