From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1172457AbdDYHHt (ORCPT ); Tue, 25 Apr 2017 03:07:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:58108 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S939299AbdDYHHj (ORCPT ); Tue, 25 Apr 2017 03:07:39 -0400 Date: Tue, 25 Apr 2017 09:07:18 +0200 From: Johannes Thumshirn To: Colin King Cc: Johannes Thumshirn , "James E . J . Bottomley" , "Martin K . Petersen" , fcoe-devel@open-fcoe.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static Message-ID: <20170425070628.GA16843@linux-x5ow.site> References: <20170424170418.9625-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170424170418.9625-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2017 at 06:04:18PM +0100, Colin King wrote: > From: Colin Ian King > > These module parameter variables don't need global scope, make them static > > Signed-off-by: Colin Ian King > --- Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850