From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1176116AbdDYHmY (ORCPT ); Tue, 25 Apr 2017 03:42:24 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:42062 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1176021AbdDYHmS (ORCPT ); Tue, 25 Apr 2017 03:42:18 -0400 Date: Tue, 25 Apr 2017 00:42:17 -0700 From: Christoph Hellwig To: Rajnikant Bhojani Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] check for null while iterating over a scatterlist table Message-ID: <20170425074217.GA22533@infradead.org> References: <1493105929-23353-1-git-send-email-rajnikant.bhojani@sibridgetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493105929-23353-1-git-send-email-rajnikant.bhojani@sibridgetech.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 01:08:49PM +0530, Rajnikant Bhojani wrote: > during iterating over a scatterlist table also need to check for NULL > along with number of scatterlist Not sure this is a good idea. Callers expect to iterate over the full number in general. Exiting early just papers over the bug instead of fixing it. A WARN_ON for this case might be a better idea.