mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: PaX Team <pageexec@freemail.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	Eric Biggers <ebiggers3@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Elena Reshetova <elena.reshetova@intel.com>,
	Hans Liljestrand <ishkamiel@gmail.com>,
	David Windsor <dwindsor@gmail.com>,
	"x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jann Horn <jann@thejh.net>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arch <linux-arch@vger.kernel.org>,
	"kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH] x86/refcount: Implement fast refcount_t handling
Date: Tue, 25 Apr 2017 11:05:58 +0200	[thread overview]
Message-ID: <20170425090558.vi4ihaqedlmph7va@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAGXu5j+tbPr04Jiv4yjJJO3h89fDxy-iWAeuoDZ2N+XDY58umw@mail.gmail.com>

On Mon, Apr 24, 2017 at 03:37:32PM -0700, Kees Cook wrote:
> On Mon, Apr 24, 2017 at 3:01 PM, Peter Zijlstra <peterz@infradead.org> wrote:

> > It does not. It just got free'ed. Nothing will stop the free from
> > happening (or already having happened).
> 
> Well, yes, but that's kind of my point. Detecting inc-from-0 is "too
> late" to offer a protection. It offers notification of a bug, rather
> than stopping an exploit from happening.

Well, your setup (panic_on_warn et al) would have it panic the box. That
will effectively stop the exploit by virtue of stopping everything.

And warn/bug/panic etc.. are I think a better option that silently
letting it happen.

  parent reply	other threads:[~2017-04-25  9:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-21 22:09 Kees Cook
2017-04-24  8:32 ` Peter Zijlstra
2017-04-24  8:53   ` [kernel-hardening] " Jann Horn
2017-04-24  9:20     ` Peter Zijlstra
2017-04-24 11:00   ` PaX Team
2017-04-24 11:15     ` Peter Zijlstra
2017-04-24 13:08       ` PaX Team
2017-04-24 13:33         ` Peter Zijlstra
2017-04-24 15:15           ` PaX Team
2017-04-24 20:40             ` Kees Cook
2017-04-24 22:01               ` Peter Zijlstra
2017-04-24 22:37                 ` Kees Cook
2017-04-25  1:11                   ` [kernel-hardening] " Rik van Riel
2017-04-25  9:05                   ` Peter Zijlstra [this message]
2017-04-25 11:26                 ` PaX Team
2017-04-25 16:36                   ` Kees Cook
2017-04-24 20:33     ` Kees Cook
2017-04-25 11:26       ` PaX Team
2017-04-25 16:39         ` Kees Cook
2017-04-26  2:14           ` PaX Team
2017-04-26  4:42             ` Kees Cook
2017-04-24 20:16   ` Kees Cook
2017-04-24 10:45 ` Peter Zijlstra
2017-04-24 20:19   ` Kees Cook
2017-04-24 10:48 ` Peter Zijlstra
2017-04-24 20:21   ` Kees Cook
2017-04-25 10:23 ` Peter Zijlstra
2017-04-25 11:26   ` PaX Team

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425090558.vi4ihaqedlmph7va@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=dwindsor@gmail.com \
    --cc=ebiggers3@gmail.com \
    --cc=elena.reshetova@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=ishkamiel@gmail.com \
    --cc=jann@thejh.net \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=pageexec@freemail.hu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®