From: Gary Bisson <gary.bisson@boundarydevices.com>
To: rtc-linux@googlegroups.com
Cc: linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com, a.zummo@towertech.it,
Gary Bisson <gary.bisson@boundarydevices.com>
Subject: [PATCH 1/4] rtc: m41t80: fix SQWE override when setting an alarm
Date: Tue, 25 Apr 2017 16:45:14 +0200 [thread overview]
Message-ID: <20170425144517.15962-2-gary.bisson@boundarydevices.com> (raw)
In-Reply-To: <20170425144517.15962-1-gary.bisson@boundarydevices.com>
Currently setting an alarm clears the SQWE bit which means that the
clock output is disabled no matter its previous state.
Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
drivers/rtc/rtc-m41t80.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index 58698d21c2c3..93684ab293f2 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -273,6 +273,9 @@ static int m41t80_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
return err;
}
+ /* Keep SQWE bit value */
+ alarmvals[0] |= (ret & M41T80_ALMON_SQWE);
+
ret = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS);
if (ret < 0)
return ret;
--
2.11.0
next prev parent reply other threads:[~2017-04-25 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 14:45 [PATCH 0/4] rtc: m41t80: improve SQW support Gary Bisson
2017-04-25 14:45 ` Gary Bisson [this message]
2017-04-25 14:45 ` [PATCH 2/4] rtc: m41t80: fix SQW dividers override when setting a date Gary Bisson
2017-04-25 14:45 ` [PATCH 3/4] rtc: m41t80: remove sqw sysfs entry Gary Bisson
2017-04-25 14:45 ` [PATCH 4/4] rtc: m41t80: add clock provider support Gary Bisson
2017-05-31 1:40 ` [PATCH 0/4] rtc: m41t80: improve SQW support Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425144517.15962-2-gary.bisson@boundarydevices.com \
--to=gary.bisson@boundarydevices.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®